Add missing checks to functional test

Author: iMattPro

tests/functional/acp_file_test.php

@@ -110,6 +110,10 @@ public function test_upload_invalid_extension()
 
 	public function test_upload_valid_file()
 	{
+		// Check icon does not yet appear in the html tags
+		$crawler = self::request('GET', 'index.php');
+		$this->assertCount(0, $crawler->filter('link[rel="apple-touch-icon"]'));
+
 		$this->login();
 		$this->admin_login();
 
@@ -118,15 +122,24 @@ public function test_upload_valid_file()
 		// Ensure there was no error message rendered
 		$this->assertContainsLang('ACP_PWA_IMG_UPLOAD_SUCCESS', $crawler->text());
 
+		// Check icon appears in the ACP as expected
 		$crawler = self::request('GET', 'adm/index.php?i=-phpbb-pwakit-acp-pwa_acp_module&mode=settings&sid=' . $this->sid);
 		$this->assertStringContainsString('foo.png', $crawler->filter('fieldset')->eq(2)->text());
+
+		// Check icon appears in the html tags as expected
+		$crawler = self::request('GET', 'index.php?sid=' . $this->sid);
+		$this->assertStringContainsString('foo.png', $crawler->filter('link[rel="apple-touch-icon"]')->attr('href'));
 	}
 
 	public function test_resync_delete_file()
 	{
 		// Manually copy image to site icon dir
 		copy($this->path . 'bar.png', __DIR__ . '/../../../../../images/site_icons/bar.png');
 
+		// Check icon does not yet appear in the html tags
+		$crawler = self::request('GET', 'index.php');
+		$this->assertCount(0, $crawler->filter('link[rel="apple-touch-icon"]'));
+
 		$this->login();
 		$this->admin_login();
 
@@ -139,6 +152,10 @@ public function test_resync_delete_file()
 		$crawler = self::submit($form);
 		$this->assertStringContainsString('bar.png', $crawler->filter('fieldset')->eq(2)->text());
 
+		// Check icon appears in the html tags as expected
+		$crawler = self::request('GET', 'index.php?sid=' . $this->sid);
+		$this->assertStringContainsString('bar.png', $crawler->filter('link[rel="apple-touch-icon"]')->attr('href'));
+
 		// Delete image
 		$form = $crawler->selectButton('delete')->form(['delete' => 'bar.png']);
 		$crawler = self::submit($form);