Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get_url has unclear error handling expectations #5

Closed
phpeterson-usf opened this issue Dec 20, 2023 · 0 comments
Closed

get_url has unclear error handling expectations #5

phpeterson-usf opened this issue Dec 20, 2023 · 0 comments
Assignees

Comments

@phpeterson-usf
Copy link
Owner

The github autograder code would like a 404 from get_url() to be a soft warning. The upload code would like 401 (bad token) to be a fatal error. Should switch to using response.raise_for_status() and let each caller handle errors as it prefers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant