Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

File check always fail after a file is deleted from the repository #912

Closed
lcdss opened this issue Jun 11, 2021 · 1 comment · May be fixed by #1055
Closed

File check always fail after a file is deleted from the repository #912

lcdss opened this issue Jun 11, 2021 · 1 comment · May be fixed by #1055
Labels
bug help wanted

Comments

@lcdss
Copy link

lcdss commented Jun 11, 2021

Q A
Version 1.3.2
Bug? yes
New feature? no
Question? no
Documentation? no
Related tickets 
file_size
=========

Large files detected:
- Controller.php exceeded the maximum size of 100M.
- BroadcastServiceProvider.php exceeded the maximum size of 100M.
- welcome.blade.php exceeded the maximum size of 100M.
- channels.php exceeded the maximum size of 100M.
- web.php exceeded the maximum size of 100M.

grumphp:
  hooks_dir: ..
  tasks:
    file_size:
      max_size: 100M
      ignore_patterns:
        - composer.lock

This happens only with deleted files. If I discard the deletion of one of these files, it will not be detected as a infraction by the file_size task.
jmdelehaye pushed a commit to jmdelehaye/grumphp that referenced this issue Nov 25, 2022
Fix phpro#912: Ignore deleted files in file_size task
fabdccc
@jmdelehaye jmdelehaye mentioned this issue Nov 25, 2022
Open
@veewee
Copy link
Contributor

veewee commented Nov 26, 2024

Closing because of inactivity.
Feel free to open up a PR with a fix if this is still an issue.

@veewee veewee closed this as completed Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #912: Ignore deleted files in file_size task jmdelehaye/grumphp
2 participants
@veewee @lcdss