Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add coverage option to infection task #1159

Closed
jose-bittacora opened this issue Nov 14, 2024 · 3 comments
Closed

Add coverage option to infection task #1159

jose-bittacora opened this issue Nov 14, 2024 · 3 comments

Comments

@jose-bittacora
Copy link

jose-bittacora commented Nov 14, 2024

Q A
Version GrumPHP 2.9.0
Bug? no
New feature? yes
Question? no
Documentation? no
Related tickets none

First of all thank you for GrumPHP, it is a tool that is not missing in any of my projects.

I think it would be a good idea to add a configuration option to the Infection task, to be able to specify the --coverage option, as indicated here: --coverage option. This way, if the coverage is already generated in another task (e.g. paratest or phpunit), the infection task will run much faster.

If present, the --skip-initial-tests should be added to the command when executed too.

Thank you very much

@veewee
Copy link
Contributor

veewee commented Nov 14, 2024

Thanks for your kind words.

It makes a lot of sense to introduce them.
Would you care to craft a PR in order to make this happen?

@jose-ba
Copy link
Contributor

jose-ba commented Nov 15, 2024

Thanks for your kind words.

It makes a lot of sense to introduce them. Would you care to craft a PR in order to make this happen?

Here it is: #1160

@veewee
Copy link
Contributor

veewee commented Nov 26, 2024

We'll continue in the PR. Thanks.

@veewee veewee closed this as completed Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants