From d81aeba849566219b0144eadf640f1776c0fb8b7 Mon Sep 17 00:00:00 2001 From: Brent Robert Date: Tue, 2 Jul 2024 15:49:45 +0200 Subject: [PATCH] PHPRO-415 Fix faulty docs --- .php-cs-fixer.php | 2 +- Api/Data/TranslationInterface.php | 4 ++-- Api/TranslationRepositoryInterface.php | 10 +++++----- CHANGELOG.md | 4 ++++ composer.json | 8 -------- 5 files changed, 12 insertions(+), 16 deletions(-) diff --git a/.php-cs-fixer.php b/.php-cs-fixer.php index 8f7e7ad..2133cf4 100644 --- a/.php-cs-fixer.php +++ b/.php-cs-fixer.php @@ -38,7 +38,7 @@ 'strict_param' => true, 'array_indentation' => true, 'compact_nullable_typehint' => true, - 'fully_qualified_strict_types' => true, + 'fully_qualified_strict_types' => false, ]) ->setFinder($finder); diff --git a/Api/Data/TranslationInterface.php b/Api/Data/TranslationInterface.php index b2e6b16..870a8df 100644 --- a/Api/Data/TranslationInterface.php +++ b/Api/Data/TranslationInterface.php @@ -69,14 +69,14 @@ public function setFrontend($frontend); /** * Retrieve existing extension attributes object or create a new one. * - * @return TranslationExtensionInterface|null + * @return \Phpro\Translations\Api\Data\TranslationExtensionInterface|null */ public function getExtensionAttributes(); /** * Set an extension attributes object. * - * @param TranslationExtensionInterface $extensionAttributes + * @param \Phpro\Translations\Api\Data\TranslationExtensionInterface $extensionAttributes * @return $this */ public function setExtensionAttributes( diff --git a/Api/TranslationRepositoryInterface.php b/Api/TranslationRepositoryInterface.php index fe0f56d..16159b6 100644 --- a/Api/TranslationRepositoryInterface.php +++ b/Api/TranslationRepositoryInterface.php @@ -11,9 +11,9 @@ interface TranslationRepositoryInterface /** * Save Translation * - * @param Data\TranslationInterface $translation + * @param \Phpro\Translations\Api\Data\TranslationInterface $translation * @throws \Magento\Framework\Exception\LocalizedException - * @return Data\TranslationInterface + * @return \Phpro\Translations\Api\Data\TranslationInterface */ public function save( Data\TranslationInterface $translation @@ -24,16 +24,16 @@ public function save( * * @param string $translationId * @throws \Magento\Framework\Exception\LocalizedException - * @return Data\TranslationInterface + * @return \Phpro\Translations\Api\Data\TranslationInterface */ public function getById($translationId); /** * Retrieve Translation matching the specified criteria. * - * @param SearchCriteriaInterface $searchCriteria + * @param \Magento\Framework\Api\SearchCriteriaInterface $searchCriteria * @throws \Magento\Framework\Exception\LocalizedException - * @return Data\TranslationSearchResultsInterface + * @return \Phpro\Translations\Api\Data\TranslationSearchResultsInterface */ public function getList( SearchCriteriaInterface $searchCriteria diff --git a/CHANGELOG.md b/CHANGELOG.md index 3fb5cc7..0b6c561 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -36,3 +36,7 @@ ### Bugfix - Fix return types console commands - Locales are not found if set in env.php and not in core_config_table + +## [1.4.1] - 2024-07-02 +### Bugfix +- Fix faulty doc blocs preventing di:compile diff --git a/composer.json b/composer.json index 943ffac..ab1affd 100644 --- a/composer.json +++ b/composer.json @@ -45,13 +45,5 @@ "magento/composer-dependency-version-audit-plugin": true, "dealerdirect/phpcodesniffer-composer-installer": true } - }, - "scripts": { - "post-install-cmd": [ - "([ $COMPOSER_DEV_MODE -eq 0 ] || vendor/bin/phpcs --config-set installed_paths ../../magento/magento-coding-standard/,../../magento/php-compatibility-fork)" - ], - "post-update-cmd": [ - "([ $COMPOSER_DEV_MODE -eq 0 ] || vendor/bin/phpcs --config-set installed_paths ../../magento/magento-coding-standard/,../../magento/php-compatibility-fork)" - ] } }