Mocks do not fail immedately on unexpected calls

[Jean85]

I've migrated to this trait since PHPUnit deprecated its integration with Prophecy.

I've struggled a little since then, but I've now found the root of my issue: mocks are not failing immediately as before.

This is a reproducer:

<?php

declare(strict_types=1);

class MockRegressionTest extends \PHPUnit\Framework\TestCase
{
    use ProphecyTrait;

    public function test(): void
    {
        $prophecy = $this->prophesize(\PHPUnit\Framework\TestSuite::class);
        $prophecy->addTestFile('foo.php')
            ->shouldBeCalledOnce();

        $prophecy->reveal()
            ->addTestFile('bar.php'); // should fail here

        $this->fail('If we got here, we have some trouble'); // goes on and fails here
    }
}

Test should fail immediately when calling the method with the wrong argument, but it doesn't. This leads to the mock returning null and either failing with a TypeError or going further, making the test failure a lot harder to debug.

Copying this reproducer into a PHPSpec test gets the right behavior.

Thanks to @DonCallisto for the help debugging this issue.

[Jean85]

I'm investigating further, and it seems that this is in reality due to phpspec/prophecy#457 and related to phpspec/prophecy#441

[stof]

Closing in favor of phpspec/prophecy#508