-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PHP 8.3 support #607
Comments
It will depend on community contributions to identify which new features of PHP 8.3 are requiring changes in Prophecy to allow doubling them. To test things, you can use the |
@rajeshreeputra having a green CI does not mean that we support PHP 8.3 though. It means we support code using older features when running on 8.3. Support for language features added in PHP 8.3 is not covered by the existing testsuite. |
I think |
Given that the |
From my perspective, what could be interesting from mocking library's perspective is:
All of them (at least first 2) in terms of optimising generated code. But it's a wild guess only, I don't know about Prophecy's internal much. |
Prophecy does not rely on anonymous classes (and currently does not support mocking readonly classes anyway as its internal implementation currently requires a mutable property in the mock class) |
typed class constants should not affect us as the generated mock class does not redefine constants. |
Ok, so the conclusion is that we don't need any additional work to support PHP 8.3, right? |
let's just bump the supported version then? |
Drupal also awaiting of new release with PHP 8.3.* support https://www.drupal.org/project/drupal/issues/3406622 |
1.18.0 has been released and includes it. |
What's the plan to provide support for PHP 8.3, which is scheduled for release on November 23, 2023, with the first RC version set to be release on August 31, 2023.
The text was updated successfully, but these errors were encountered: