use conditionalTags

Author: staabm

rules.neon

@@ -9,6 +9,10 @@ rules:
 	- PHPStan\Rules\PHPUnit\NoMissingSpaceInMethodAnnotationRule
 	- PHPStan\Rules\PHPUnit\ShouldCallParentMethodsRule
 
+conditionalTags:
+    PHPStan\Rules\PHPUnit\AssertEqualsIsDiscouragedRule:
+        phpstan.rules.rule: [%strictRulesInstalled%, %featureToggles.bleedingEdge%]
+
 services:
 	-
 		class: PHPStan\Rules\PHPUnit\DataProviderDeclarationRule
@@ -20,7 +24,3 @@ services:
 
 	-
 		class: PHPStan\Rules\PHPUnit\AssertEqualsIsDiscouragedRule
-		arguments:
-			strictRulesInstalled: %strictRulesInstalled%
-		tags:
-			- phpstan.rules.rule

src/Rules/PHPUnit/AssertEqualsIsDiscouragedRule.php

@@ -18,26 +18,13 @@
 class AssertEqualsIsDiscouragedRule implements Rule
 {
 
-	private bool $strictRulesInstalled;
-
-	public function __construct(
-		bool $strictRulesInstalled
-	)
-	{
-		$this->strictRulesInstalled = $strictRulesInstalled;
-	}
-
 	public function getNodeType(): string
 	{
 		return NodeAbstract::class;
 	}
 
 	public function processNode(Node $node, Scope $scope): array
 	{
-		if (!$this->strictRulesInstalled) {
-			return [];
-		}
-
 		if (!AssertRuleHelper::isMethodOrStaticCallOnAssert($node, $scope)) {
 			return [];
 		}

tests/Rules/PHPUnit/AssertEqualsIsDiscouragedRuleTest.php

@@ -32,7 +32,7 @@ public function testRule(): void
 
 	protected function getRule(): Rule
 	{
-		return new AssertEqualsIsDiscouragedRule(true);
+		return new AssertEqualsIsDiscouragedRule();
 	}
 
 }