Test ContinueBreakInLoopRule for property hooks

Author: ondrejmirtes

Makefile

@@ -43,6 +43,7 @@ lint:
 		--exclude tests/PHPStan/Rules/Functions/data/arrow-function-nullsafe-by-ref.php \
 		--exclude tests/PHPStan/Levels/data/namedArguments.php \
 		--exclude tests/PHPStan/Rules/Keywords/data/continue-break.php \
+		--exclude tests/PHPStan/Rules/Keywords/data/continue-break-property-hook.php \
 		--exclude tests/PHPStan/Rules/Properties/data/invalid-callable-property-type.php \
 		--exclude tests/PHPStan/Rules/Properties/data/properties-in-interface.php \
 		--exclude tests/PHPStan/Rules/Properties/data/read-only-property.php \

src/Rules/Keywords/ContinueBreakInLoopRule.php

@@ -39,11 +39,7 @@ public function processNode(Node $node, Scope $scope): array
 			if ($parentStmtType === Stmt\Case_::class) {
 				continue;
 			}
-			if (
-				$parentStmtType === Stmt\Function_::class
-				|| $parentStmtType === Stmt\ClassMethod::class
-				|| $parentStmtType === Node\Expr\Closure::class
-			) {
+			if ($parentStmtType === Node\Expr\Closure::class) {
 				return [
 					RuleErrorBuilder::message(sprintf(
 						'Keyword %s used outside of a loop or a switch statement.',

tests/PHPStan/Rules/Keywords/ContinueBreakInLoopRuleTest.php

@@ -4,6 +4,7 @@
 
 use PHPStan\Rules\Rule;
 use PHPStan\Testing\RuleTestCase;
+use const PHP_VERSION_ID;
 
 /**
  * @extends RuleTestCase<ContinueBreakInLoopRule>
@@ -46,4 +47,34 @@ public function testRule(): void
 		]);
 	}
 
+	public function testPropertyHooks(): void
+	{
+		if (PHP_VERSION_ID < 80400) {
+			$this->markTestSkipped('Test requires PHP 8.4.');
+		}
+
+		$this->analyse([__DIR__ . '/data/continue-break-property-hook.php'], [
+			[
+				'Keyword break used outside of a loop or a switch statement.',
+				13,
+			],
+			[
+				'Keyword break used outside of a loop or a switch statement.',
+				15,
+			],
+			[
+				'Keyword break used outside of a loop or a switch statement.',
+				24,
+			],
+			[
+				'Keyword continue used outside of a loop or a switch statement.',
+				26,
+			],
+			[
+				'Keyword break used outside of a loop or a switch statement.',
+				35,
+			],
+		]);
+	}
+
 }

tests/PHPStan/Rules/Keywords/data/continue-break-property-hook.php

@@ -0,0 +1,41 @@
+<?php // lint >= 8.4
+
+namespace ContinueBreakPropertyHook;
+
+class Foo
+{
+
+	public int $bar {
+		set (int $foo) {
+			foreach ([1, 2, 3] as $val) {
+				switch ($foo) {
+					case 1:
+						break 3;
+					default:
+						break 3;
+				}
+			}
+		}
+	}
+
+	public int $baz {
+		get {
+			if (rand(0, 1)) {
+				break;
+			} else {
+				continue;
+			}
+		}
+	}
+
+	public int $ipsum {
+		get {
+			foreach ([1, 2, 3] as $val) {
+				function (): void {
+					break;
+				};
+			}
+		}
+	}
+
+}

tests/PHPStan/Rules/Keywords/data/continue-break.php

@@ -94,3 +94,64 @@ function (): void {
 if (rand(0, 1)) {
 	break;
 }
+
+class ValidUsages
+{
+
+	public int $i {
+		set (int $foo) {
+			switch ($foo) {
+				case 1:
+					break;
+				default:
+					break;
+			}
+
+			foreach ([1, 2, 3] as $val) {
+				if (rand(0, 1)) {
+					break;
+				} else {
+					continue;
+				}
+			}
+
+			for ($i = 0; $i < 5; $i++) {
+				if (rand(0, 1)) {
+					break;
+				} else {
+					continue;
+				}
+			}
+
+			while (true) {
+				if (rand(0, 1)) {
+					break;
+				} else {
+					continue;
+				}
+			}
+
+			do {
+				if (rand(0, 1)) {
+					break;
+				} else {
+					continue;
+				}
+			} while (true);
+		}
+	}
+
+	public int $j {
+		set (int $foo) {
+			foreach ([1, 2, 3] as $val) {
+				switch ($foo) {
+					case 1:
+						break 2;
+					default:
+						break 2;
+				}
+			}
+		}
+	}
+
+}