Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track API URL in .phylum_project (if not prod) #430

Open
kylewillmon opened this issue May 26, 2022 · 0 comments
Open

Track API URL in .phylum_project (if not prod) #430

kylewillmon opened this issue May 26, 2022 · 0 comments
Labels
enhancement New feature or request low priority Should be handled as time permits question Further information is requested

Comments

@kylewillmon
Copy link
Contributor

kylewillmon commented May 26, 2022

The .phylum_project file contains the Project ID and (optionally) group name. But it does not contain the API URL. This leads to unknown project errors if a .phylum_project file is, for example, created on staging and then run against prod.

It would be nice if we tracked the API URL in the .phylum_project file. To avoid clutter, we could skip adding the URL if it matches the default (which is prod).

Then, at a minimum, we can check it against the configured URL and give a more reasonable error message. Or, more preferably, we could update the config format to store URL/token pairs, and execute queries against the correct instance per project.

This would also help phylum-ci now that it is using the .phylum_project file to build the project URL (as of phylum-dev/phylum-ci#54)

It's very possible that this idea would cause more trouble than it's worth, but I think it's worth considering.

@kylewillmon kylewillmon added enhancement New feature or request needs triage Needs to be reviewed or assigned low priority Should be handled as time permits and removed needs triage Needs to be reviewed or assigned labels May 26, 2022
@kylewillmon kylewillmon added the question Further information is requested label Jun 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request low priority Should be handled as time permits question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant