Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark mode in combination with group tabs is not readable #52

Open
ThijsSassen opened this issue Apr 4, 2023 · 4 comments
Open

Dark mode in combination with group tabs is not readable #52

ThijsSassen opened this issue Apr 4, 2023 · 4 comments

Comments

@ThijsSassen
Copy link

When using dark mode and group tabs the text inside the tabs is not visible

for an example see here

@dantownsend
Copy link
Member

Thanks for reporting this.

Is this using the sphinx-tabs library?

@ThijsSassen
Copy link
Author

@dantownsend yes it is

@dantownsend
Copy link
Member

Looks like sphinx-tabs explicitly sets the background colour to white.

I'd add this to your CSS file, and it'll fix it:

.sphinx-tabs-panel {
    background: none;
}

We could add this override to the Piccolo theme, but it feels a bit fragile overriding the styles of other libraries.

It looks like they do support a dark theme by adding data-theme="dark" to the body tag. That's probably the best solution, though it does tie us to a third party library.

https://github.com/executablebooks/sphinx-tabs/blob/9431223384729010ba29c27c2d2976ce76b7e1ad/sphinx_tabs/static/tabs.css#L76

@ThijsSassen
Copy link
Author

@dantownsend thanks that worked

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants