PickleFinance Failed Tests

[MisterMard]

Pf-core's test suites currently fails with plenty of errors:

Test Suites: 3 failed, 2 passed, 5 total
Tests:       4 failed, 11 passed, 15 total
Snapshots:   0 total
Time:        62.938 s
Ran all test suites.

---

Known issues and fixes so far:

• Failed UserModel. fixed (b0bb949)

Details

● Testing user model › Ensure user model actually returns

    TypeError: Cannot read properties of undefined (reading 'minichef')

      678 |     chainAssets: PickleModelJson.JarDefinition[],
      679 |   ): Promise<StakedAndPendingRet> {
    > 680 |     const chef = ADDRESSES.get(chain).minichef;
          |                  ^
      681 |     const skip: boolean =
      682 |       chef === null || chef === undefined || chef === NULL_ADDRESS;
      683 |     if (skip) {

Fix: Add Gnosis chain addresses to PickleModel.

• Active jars have no behaviours. fixed (aa9b63f)

Details

● Testing defined model › Ensure all active assets have a behavior

    expect(received).toBe(expected) // Object.is equality

    Expected: 0
    Received: 5

      159 |     }
      160 |     console.log("Errors: " + JSON.stringify(err));
    > 161 |     expect(err.length).toBe(0);
          |                        ^
      162 |   });
      163 |
      164 |   test("Ensure all deposit token components are in the external token model", async () => {

Fix: Assign the proper behaviour to the following NearPad jars (or label as inactive):

1. nearJar 3g.
2. nearJar 3h.
3. nearJar 3k.
4. nearJar 3i.
5. nearJar 3j.

Errors: ["Asset nearJar 3g has no associated behavior file","Asset nearJar 3h has no associated behavior file","Asset nearJar 3k has no associated behavior file","Asset nearJar 3i has no associated behavior file","Asset nearJar 3j has no associated behavior file"]

• Jars with custom harvester have no harvester assigned. fixed (aa9b63f)

Details

● Testing defined model › Ensure all jars with custom harvester have a harvester

    expect(received).toBe(expected) // Object.is equality

    Expected: 0
    Received: 7

      224 |     }
      225 |     console.log("Errors: " + JSON.stringify(err));
    > 226 |     expect(err.length).toBe(0);
          |                        ^
      227 |   });
      228 | });
      229 |

Fix: Assign proper behaviour class/custom harvester to the following jars:

1. nearJar 3g
2. nearJar 3h
3. nearJar 3i
4. nearJar 3j
5. nearJar 4a
6. nearJar 4d
7. nearJar 4e

Errors: ["NLP-PAD-MODA has no behavior class","NLP-PAD-DAI has no behavior class","NLP-NEAR-ETH has no behavior class","NLP-PAD-TRI has no behavior class","NLP-PAD-ROSE has no custom harvester","ROSELP-FRAXPOOL has no custom harvester","ROSELP-USTPOOL has no custom harvester"]

• A few tokens have no description. fixed (87768f4)

Details

● Testing documentation model › Ensure all tokens have descriptions and documentation

    expect(received).toBe(expected) // Object.is equality

    Expected: 0
    Received: 1

      36 |     }
      37 |     console.log(JSON.stringify(err, null, 2));
    > 38 |     expect(err.length).toBe(0);
         |                        ^
      39 |
      40 |   });
      41 | });

Fix: Add description for ply, stksm and xcksm tokens:

[
        "Token stksm on chain moonriver has no description",
        "Token xcksm on chain moonriver has no description",
        "Token ply on chain aurora has no description"
]

• Some jars have no description.

Details

● Testing documentation model › Ensure all jars have documentation

    expect(received).toBe(expected) // Object.is equality

    Expected: 0
    Received: 10

      19 |     }
      20 |     console.log(JSON.stringify(err, null, 2));
    > 21 |     expect(err.length).toBe(0);
         |                        ^

Fix: Add manual descriptions for the following jars:

console.log
[
        "TECTONIC-WETH Has no documentation in English",
        "TECTONIC-CRO Has no documentation in English",
        "NLP-PAD-ROSE Has no documentation in English",
        "NLP-FRAX-ROSE Has no documentation in English",
        "ROSELP-3POOL Has no documentation in English",
        "ROSELP-FRAXPOOL Has no documentation in English",
        "ROSELP-USTPOOL Has no documentation in English",
        "ROSELP-BUSDPOOL Has no documentation in English",
        "ROSELP-MAIPOOL Has no documentation in English",
        "ROSELP-RUSDPOOL Has no documentation in English"
]