chore(general): allow empty model initialization #126
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e model object in order to avoid UI issues
…del object in order to avoid UI issues
…l object in order to avoid UI issues
…object in order to avoid UI issues
…bject in order to avoid UI issues
… in order to avoid UI issues
…object in order to avoid UI issues
…del object in order to avoid UI issues
…object in order to avoid UI issues
… model object in order to avoid UI issues
… in order to avoid UI issues
…object in order to avoid UI issues
…el object in order to avoid UI issues
…or both config and controller
…th config and controller
…h config and controller
…config and controller
…oth config and controller
…config and controller
# Conflicts: # packages/ruler/configure/src/index.js
|
thanks @sergiulucaci will look in the morning! |
|
thanks @sergiulucaci can you check with @elodszopos about math-inline? |
|
Verified with @sergiulucaci that the math-inline textarea in question is working as intended. No problems with the interaction. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to resolve #124 ticket.
Since this is my first contact with all packages, there might be some default values that you expect to see but ignored by me, so please review carefully default values chosen.
Besides this, there are two UI panels that seem not to work properly:
and I'm not sure if those are known issues or WIP, but if not, we could create tickets for those.
For some packages I avoided to use arrow-body-style for consistency purposes.