Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HttpHelper wrongly passes url as std::string #106

Open
Epse opened this issue Jan 1, 2023 · 0 comments
Open

HttpHelper wrongly passes url as std::string #106

Epse opened this issue Jan 1, 2023 · 0 comments

Comments

@Epse
Copy link

Epse commented Jan 1, 2023

In HttpHelper, URLs are passed to libcurl as std::string, where they should be char pointers, thus breaking things like CPDLC, due to libcurl errors.
The std::string.c_str() method is exactly what's needed here.

See:

curl_easy_setopt(curl, CURLOPT_URL, url);

If some more time can be given, I can prepare a patch to fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant