Avoid using variable name I in C code
#226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- as it might interfere with C's own macro for complex numbers defined in the `complex.h` library
- due to breaking changes to its C API
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #226 +/- ##
==========================================
+ Coverage 66.91% 66.94% +0.03%
==========================================
Files 44 44
Lines 6193 6151 -42
==========================================
- Hits 4144 4118 -26
+ Misses 2049 2033 -16 ☔ View full report in Codecov by Sentry. |
- to improve test coverage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as was the case in
core/_ext/src_numerics.c.This is because
Iis already used for complex numbers in thecomplex.hlibrary (see #225).Note that the remaining functions contained in that file should eventually be migrated to
core/_ext/numerics.pyx.Also, the newly released Numpy 2.0 introduces breaking changes with its C API. Migration should be considered at some point using the provided giude.