Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CLUSTER_NAME environment variable to CI job system metadata #1148

Closed
wants to merge 3 commits into from
Closed

Add CLUSTER_NAME environment variable to CI job system metadata #1148

wants to merge 3 commits into from

Conversation

msimberg
Copy link
Contributor

@msimberg msimberg commented Jun 5, 2024

This should fix #1062.

@msimberg msimberg added this to the 0.26.0 milestone Jun 5, 2024
@msimberg msimberg self-assigned this Jun 5, 2024
@pika-bot
Copy link
Collaborator

pika-bot commented Jun 5, 2024

Performance test report

pika Performance

Comparison

BENCHMARKRESULT
Task Overhead - Create Thread Hierarchical - Latch-

Info

PropertyBeforeAfter
pika Datetime2024-02-19T15:15:15+00:002024-06-05T11:12:10+00:00
pika Commit0abc0846e6bc20
Envfile
Datetime2024-02-19T16:26:16.072067+01:002024-06-05T13:18:58.148322+02:00
Clusternamedaintdaint
Hostnamenid00025nid00025
Compiler/apps/daint/SSL/pika/spack/lib/spack/env/clang/clang++ 11.0.1/apps/daint/SSL/pika/spack/lib/spack/env/clang/clang++ 11.0.1

Explanation of Symbols

SymbolMEANING
=No performance change (confidence interval within ±1%)
(=)Probably no performance change (confidence interval within ±2%)
(+)/(-)Very small performance improvement/degradation (≤1%)
+/-Small performance improvement/degradation (>10%)
++/--Large performance improvement/degradation (>10%)
+++/---Very large performance improvement/degradation (>10%)
?Probably no change, but quite large uncertainty (confidence interval with ±5%)
??Unclear result, very large uncertainty (±10%)
???Something unexpected…

@pika-bot
Copy link
Collaborator

pika-bot commented Jun 6, 2024

Performance test report

pika Performance

Comparison

BENCHMARKRESULT
Task Overhead - Create Thread Hierarchical - Latch-

Info

PropertyBeforeAfter
pika Datetime2024-02-19T15:15:15+00:002024-06-06T06:52:34+00:00
pika Commit0abc084bbb28a8
Hostnamenid00025nid00025
Datetime2024-02-19T16:26:16.072067+01:002024-06-06T09:01:51.361899+02:00
Envfile
Clusternamedaintdaint
Compiler/apps/daint/SSL/pika/spack/lib/spack/env/clang/clang++ 11.0.1/apps/daint/SSL/pika/spack/lib/spack/env/clang/clang++ 11.0.1

Explanation of Symbols

SymbolMEANING
=No performance change (confidence interval within ±1%)
(=)Probably no performance change (confidence interval within ±2%)
(+)/(-)Very small performance improvement/degradation (≤1%)
+/-Small performance improvement/degradation (>10%)
++/--Large performance improvement/degradation (>10%)
+++/---Very large performance improvement/degradation (>10%)
?Probably no change, but quite large uncertainty (confidence interval with ±5%)
??Unclear result, very large uncertainty (±10%)
???Something unexpected…

@msimberg
Copy link
Contributor Author

msimberg commented Jun 6, 2024

Closing. CLUSTER_NAME is only set in login shells and slurm jobs are not run in login shells. I'll come back to this if we need this badly. Until then SLURM_CLUSTER_NAME works just fine (clariden doesn't exist right now, so #1062 is a non-issue at the moment).

@msimberg msimberg closed this Jun 6, 2024
@aurianer
Copy link
Contributor

aurianer commented Jun 10, 2024 •
edited
Loading

Could actually be a variable nice to have here: https://gitlab.com/cscs-ci/recipes/-/raw/master/templates/v2/.ci-ext.yml

@msimberg msimberg deleted the cscs-ci-metadata-cluster-name branch June 11, 2024 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aurianer aurianer Awaiting requested review from aurianer aurianer is a code owner

@biddisco biddisco Awaiting requested review from biddisco biddisco is a code owner

Assignees

@msimberg msimberg

Labels
None yet
Projects
pika planning board
Status: Archive
Milestone
0.26.0
Development

Successfully merging this pull request may close these issues.

Add CSCS cluster name to elastic metadata
3 participants
@msimberg @pika-bot @aurianer