Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor PIKA_MPI_COMPLETION_MODE into independent flags #1144

Open
msimberg opened this issue Jun 3, 2024 · 0 comments
Open

Refactor PIKA_MPI_COMPLETION_MODE into independent flags #1144

msimberg opened this issue Jun 3, 2024 · 0 comments
Labels
category: senders/receivers P2300 effort: 3 A few days of work. priority: high This is essential functionality or a serious bug. Not addressing this blocks progress. type: cleanup type: refactoring

Comments

@msimberg
Copy link
Contributor

msimberg commented Jun 3, 2024

While for testing the current bitmask passed to PIKA_MPI_COMPLETION_MODE is convenient, the values are not very transparent to a user setting the values. It'd be nice to split up the flags into PIKA_MPI_INLINE_CONTINUATION, PIKA_MPI_DEDICATED_POOL etc. If still needed for testing we can consider keeping some way to override the mode with a bitmask as well.
@msimberg msimberg added effort: 3 A few days of work. priority: high This is essential functionality or a serious bug. Not addressing this blocks progress. type: refactoring category: senders/receivers P2300 type: cleanup labels Jun 3, 2024
@msimberg msimberg mentioned this issue Jun 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
category: senders/receivers P2300 effort: 3 A few days of work. priority: high This is essential functionality or a serious bug. Not addressing this blocks progress. type: cleanup type: refactoring
Projects
pika planning board
Status: Backlog
Milestone
No milestone
Development

No branches or pull requests
1 participant
@msimberg