You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The historical function returns an empty array [] on any kind of error (network error, symbol not found, etc). While investigating I found there is an undocumented option error that can be set to true to get errors thrown.
I believe it is better to remove this option and just throw the errors so the user of the module can handle the errors the way they like.
Same applies to companyNews and yahoo-finance.historical.
If you agree I can make a PR request for it.
The text was updated successfully, but these errors were encountered:
The
historical
function returns an empty array[]
on any kind of error (network error, symbol not found, etc). While investigating I found there is an undocumented optionerror
that can be set totrue
to get errors thrown.I believe it is better to remove this option and just throw the errors so the user of the module can handle the errors the way they like.
Same applies to
companyNews
andyahoo-finance.historical
.If you agree I can make a PR request for it.
The text was updated successfully, but these errors were encountered: