Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace progress bars by crossterm-based ones #1

Open
soywod opened this issue Sep 3, 2024 · 2 comments
Open

Replace progress bars by crossterm-based ones #1

soywod opened this issue Sep 3, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@soywod
Copy link
Member

soywod commented Sep 3, 2024

Progress bars actually come from indicatif, which is based on console. Since all other components migrated to crossterm, we need to replace progress bars and spinners by crossterm-based ones.

@soywod soywod added this to Pimalaya Sep 3, 2024
@soywod soywod moved this to Todo in Pimalaya Sep 3, 2024
@soywod soywod added the enhancement New feature or request label Sep 3, 2024
@shymega
Copy link

shymega commented Sep 3, 2024

The interesting thing is that neverest sync does show the progress bar, but I was running it with --dry-run when I mentioned it to you. If you do it in dry run mode, the progress bar does not appear.

@soywod
Copy link
Member Author

soywod commented Sep 3, 2024

Ah yes indeed, --dry-run runs so fast for me that I never realized they don't move. Good to keep in mind for the replacement!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: No status
Development

No branches or pull requests

2 participants