From 4b356e913cf1f795175eb0dd37742d00bce531d1 Mon Sep 17 00:00:00 2001 From: Adam Fuller Date: Tue, 7 Jan 2025 19:50:30 +0000 Subject: [PATCH 1/4] use localOwners in signUserOperation --- packages/permissionless/accounts/safe/toSafeSmartAccount.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/permissionless/accounts/safe/toSafeSmartAccount.ts b/packages/permissionless/accounts/safe/toSafeSmartAccount.ts index e49dd5f7..c76b468d 100644 --- a/packages/permissionless/accounts/safe/toSafeSmartAccount.ts +++ b/packages/permissionless/accounts/safe/toSafeSmartAccount.ts @@ -1525,7 +1525,7 @@ export async function toSafeSmartAccount< let signatures: Hex | undefined = undefined - for (const owner of owners) { + for (const owner of localOwners) { signatures = await signUserOperation({ ...userOperation, version, From 35418aeccd0cca9a3b6ff067158fcb5fd5548d42 Mon Sep 17 00:00:00 2001 From: azf20 Date: Tue, 7 Jan 2025 21:25:45 +0000 Subject: [PATCH 2/4] changeset --- .changeset/four-eggs-deny.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/four-eggs-deny.md diff --git a/.changeset/four-eggs-deny.md b/.changeset/four-eggs-deny.md new file mode 100644 index 00000000..03f1bcd3 --- /dev/null +++ b/.changeset/four-eggs-deny.md @@ -0,0 +1,5 @@ +--- +"permissionless": patch +--- + +fix safe userOp signing From b50bb3867375654220bd1a7c25bd857327b98488 Mon Sep 17 00:00:00 2001 From: Garvit Khatri Date: Wed, 8 Jan 2025 18:24:06 +0530 Subject: [PATCH 3/4] Update four-eggs-deny.md --- .changeset/four-eggs-deny.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.changeset/four-eggs-deny.md b/.changeset/four-eggs-deny.md index 03f1bcd3..c4caa9ca 100644 --- a/.changeset/four-eggs-deny.md +++ b/.changeset/four-eggs-deny.md @@ -2,4 +2,4 @@ "permissionless": patch --- -fix safe userOp signing +Fixed `signUserOperation` for `toSafeSmartAccount` when owner is not a LocalAccount. From bae15ee054ddb171537e997b822557d73f0ff6e4 Mon Sep 17 00:00:00 2001 From: Garvit Khatri Date: Wed, 8 Jan 2025 13:12:02 +0000 Subject: [PATCH 4/4] make forkUrl optional --- packages/permissionless-test/src/testWithRpc.ts | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/packages/permissionless-test/src/testWithRpc.ts b/packages/permissionless-test/src/testWithRpc.ts index 3d02a66e..c7c965bc 100644 --- a/packages/permissionless-test/src/testWithRpc.ts +++ b/packages/permissionless-test/src/testWithRpc.ts @@ -30,11 +30,16 @@ export const getInstances = async ({ | string | undefined - const anvilInstance = anvil({ - chainId: foundry.id, - port: anvilPort, - forkUrl - }) + const anvilInstance = forkUrl + ? anvil({ + chainId: foundry.id, + port: anvilPort, + forkUrl + }) + : anvil({ + chainId: foundry.id, + port: anvilPort + }) const altoInstance = alto({ entrypoints: [entryPoint06Address, entryPoint07Address],