Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document that list colors need a compatible terminal #297

Open
untitaker opened this issue Jan 18, 2018 · 2 comments · May be fixed by #462
Open

Document that list colors need a compatible terminal #297

untitaker opened this issue Jan 18, 2018 · 2 comments · May be fixed by #462

Comments

@untitaker
Copy link
Member

untitaker commented Jan 18, 2018

In e.g. #251 there has been some confusion about list colors not showing. We could:

or, alternatively:

  • round colors to the next 16-bit color for terminals that don't support it. This will loose colour information, not sure if desirable
@untitaker
Copy link
Member Author

@WhyNotHugo please advise if you think it's better to support more terminals or to use 256-bit colors. Theoretically we can do both (have 256-bit colors but have a fallback for old terminals) but it'd be messy

@WhyNotHugo
Copy link
Member

I'd stick to documenting it as a requirement. Not sure if the command is worth it, but I wouldn't be against a check command that checks this (I say check, because we might want to extend it to other checks that come up in future).

I'm open to PRs for supporting terminals that don't support 24-bit colours though, if somebody cares enough, but I wouldn't worry about it ourselves.

@Misterio77 Misterio77 linked a pull request Oct 23, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants