Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependencies version aren't fixed #583

Open
martinvol opened this issue Aug 9, 2018 · 1 comment
Open

Dependencies version aren't fixed #583

martinvol opened this issue Aug 9, 2018 · 1 comment

Comments

@martinvol
Copy link
Contributor

Issue Summary

A short summary of the issue

pixax-stripe uses stripe>=2.0 as dependency, as defined here. This causes that deployments of the code without changing dependencies could break because they are incompatible with the deployed code.

Steps to Reproduce

It can't be downloaded and reproduced, because your project will break as stripe changes they Python Library API.

In my case, the issue caused the following problem

  1. Use stripe.CardError
  2. Someday after a deployment, my server re-installed the dependencies and I got AttributeError: module 'stripe' has no attribute 'CardError'

What were you expecting to happen?

Every version of pinax-stripe should be expected to work with only one version of stripe.

What actually happened?

martinvol added a commit to martinvol/pinax-stripe that referenced this issue Aug 9, 2018
@blueyed
Copy link
Contributor

blueyed commented Aug 9, 2018

I think the problem is that it was not pinned previously, which was done in bb25a05.

Maybe you updated stripe before pinax-stripe already?
Would be good to have your full traceback to see if it is from pinax-stripe, or maybe even your own app.

I think this issue can be closed, with further discussion in #584.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants