Hide location name when it overlaps machine count on map #565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wait, realized it's always hiding the text, regardless of how zoomed in or if it's actually overlapping the machine count 🤦
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Attempts to fix #540. Just tried what @RyanTG had already suggested and it seems to work (in a single case):
I haven't really tested this, but I'll play around with the app some more. Would an automated test be needed? Seems like it'd be a little involved.
Changes
Before
After
Notes
SymbolLayeris moved, something about the ID changing:WARN Mapbox [warning] Changing id from: symbol-id1 to symbol-id2, changing of id is supported. However, this goes away once the app is reloaded.