Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In the example, a task is created with status: null instead of open #763

Open
SEGVeenstra opened this issue Jul 3, 2023 · 6 comments · May be fixed by #764
Open

In the example, a task is created with status: null instead of open #763

SEGVeenstra opened this issue Jul 3, 2023 · 6 comments · May be fixed by #764

Comments

@SEGVeenstra
Copy link
Collaborator

This means the filter in the example is set to 'open', new tasks will not be shown.

When the user swipes to update the status, the status will jump to inProgress, thus skipping open.
@SEGVeenstra SEGVeenstra linked a pull request Jul 3, 2023 that will close this issue
Open
@dkaera
Copy link
Collaborator

dkaera commented Jul 13, 2023 •
edited
Loading

@SEGVeenstra in the example I wanted to show that null values are also supported. Your option makes sense if it looks more visual for general understanding.

@SEGVeenstra
Copy link
Collaborator Author

@dkaera I see!
Well maybe open should then just be added as an extra step.

So it's starts as uncategorized (should be filter option as well) > open > inProgress > done.

Or maybe remove the open for that matter, but add the filter for the uncategorized (null).

@dkaera
Copy link
Collaborator

dkaera commented Jul 13, 2023

@SEGVeenstra
yes, I agree with you. Adding the uncategorized filter should give more understanding.

@SEGVeenstra
Copy link
Collaborator Author

@dkaera Ok, I will update the PR probably tomorrow.

@SEGVeenstra
Copy link
Collaborator Author

Wasn't able to work on it last week, but I checked it out just now.
Adding the uncategorized creates more work than I would like.

Currently the menu items are generated by the possible categories (open, In Progress, Done), with one extra, for showing 'All'.

This is being translated to the selected TaskStatus. For this null is already used for 'All' and thus cannot be used as filter.

I've made some changes to support the uncategorized option in the PR.

I also noticed the unused property: TaskType.
Maybe we could think about a more excessive example showing a bit more in the future.

@SEGVeenstra
Copy link
Collaborator Author

The test for the example fails on the analyzer.
I've fixed all but the last one, about the library_private_types_in_public_api rule.
Also mentioned in: #742

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add TaskStatus.open as status when creating a new task pinchbv/floor
2 participants
@dkaera @SEGVeenstra