Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

test: fix integration test which may cause case fail sometimes #2153

Merged
merged 1 commit into from
Sep 22, 2021
Merged

test: fix integration test which may cause case fail sometimes #2153

merged 1 commit into from
Sep 22, 2021

Conversation

D3Hunter
Copy link
Contributor

integration test: fix invalid pgrep expression which may cause case fail sometime; add sleep to all_mode test(may fail sometimes)

What problem does this PR solve?

some integration test case(all_mode) may fail sometimes(when process doesn't exit fast enough or delayed)

What is changed and how it works?

  • fix pgrep expression in wait_pattern_exit
  • add sleep 2 to integration test case all_mode

Check List

Tests

  • No code

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 18, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • glorv
  • lance6716

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@CLAassistant
Copy link

CLAassistant commented Sep 18, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@ti-chi-bot
Copy link
Member

Welcome @D3Hunter!

It looks like this is your first PR to pingcap/dm 🎉.

I'm the bot to help you request reviewers, add labels and more, See available commands.

We want to make sure your contribution gets all the attention it needs!



Thank you, and welcome to pingcap/dm. 😃

@lance6716 lance6716 changed the title fix integration test which may cause case fail sometimes test: fix integration test which may cause case fail sometimes Sep 18, 2021
@okJiang
Copy link
Member

okJiang commented Sep 18, 2021 •
edited
Loading

Hi, thanks for your first contribution.

Does this pr resolve the unstable test case all_mode in #2073?

If so, you can link them😊.

@D3Hunter
Copy link
Contributor Author

Hi, thanks for your first contribution.

Does this pr resolve the unstable test case all_mode in #2073?

If so, you can link them😊.

jenkins 2161 is the case i met for adding sleep 2.

@ti-chi-bot ti-chi-bot added the status/LGT1 One reviewer already commented LGTM label Sep 22, 2021
glorv
glorv approved these changes Sep 22, 2021
View reviewed changes
tests/_utils/test_prepare
@@ -32,7 +32,7 @@ function wait_pattern_exit() {
pattern=$1
while true
do
if [ "pgrep -f $pattern" != "0" ]; then
if ! pgrep -f $pattern >/dev/null 2>&1; then
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also fix the typo in L36 echo "pattern $pattern already exist"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems not a typo, it should be process with pattern $pattern already exit

@ti-chi-bot ti-chi-bot added status/LGT2 Two reviewers already commented LGTM, ready for merge and removed status/LGT1 One reviewer already commented LGTM labels Sep 22, 2021
@D3Hunter
integration test: fix invalid pgrep expression which may cause case f…
5d1b29a 
…ail sometime; add sleep to all_mode test(may fail sometimes)
@lance6716 lance6716 added the needs-cherry-pick-release-2.0 This PR should be cherry-picked to release-2.0. Remove this label after cherry-picked to release-2.0 label Sep 22, 2021
@lance6716
Copy link
Collaborator

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 5d1b29a

@ti-chi-bot ti-chi-bot merged commit 2a07fd7 into pingcap:master Sep 22, 2021
@ti-chi-bot ti-chi-bot mentioned this pull request Sep 22, 2021
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #2155.

ti-chi-bot added a commit that referenced this pull request Sep 23, 2021
@ti-chi-bot
test: fix integration test which may cause case fail sometimes (#2153) (
c8c9187 
#2155)
@D3Hunter D3Hunter deleted the fix-integration-test branch September 23, 2021 02:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@glorv glorv glorv approved these changes

@lance6716 lance6716 lance6716 approved these changes

@lichunzhu lichunzhu Awaiting requested review from lichunzhu

Assignees
No one assigned
Labels
contribution For contributor first-time-contributor needs-cherry-pick-release-2.0 This PR should be cherry-picked to release-2.0. Remove this label after cherry-picked to release-2.0 size/XS status/can-merge status/LGT2 Two reviewers already commented LGTM, ready for merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@D3Hunter @ti-chi-bot @CLAassistant @okJiang @lance6716 @glorv