Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tiflash 的 redact_info_log 配置项描述 #17912

Open
shawn0915 opened this issue Jul 11, 2024 · 2 comments
Open

tiflash 的 redact_info_log 配置项描述 #17912

shawn0915 opened this issue Jul 11, 2024 · 2 comments

Comments

@shawn0915
Copy link
Contributor

Question

This repository is ONLY used to solve problems related to DOCS-CN.
For other issues (TiDB, TiKV, etc), please move to other repositories.

Before asking a question, make sure you have:

  • Searched existing Stack Overflow questions.
  • Googled your question.

Now, please describe your question here:

https://github.com/pingcap/docs-cn/blob/master/tiflash/tiflash-configuration.md?plain=1#L249

@JaySon-Huang @qiancai
249行使用的的是 -, 250行使用的是 _,可以统一下么?

-- 249
security.redact-info-log
-- 250
redact_info_log
-- 280
redact-info-log
@JaySon-Huang
Copy link
Contributor

JaySon-Huang commented Jul 11, 2024

这个是历史遗留问题,tiflash 配置项大多数是用 '_' 的。但是 tiflash-proxy 是基于 tikv 的,tikv 的配置项大多数用 '-'。这会导致 同样配置脱敏行为,或者安全证书配置的时候,tiflash 的配置项设置显得有些不协调。

这个如果要做,需要 tiflash 配置项的解析代码做些兼容,不是只修改文档就可以的。

@shawn0915
Copy link
Contributor Author

这个是历史遗留问题,tiflash 配置项大多数是用 '_' 的。但是 tiflash-proxy 是基于 tikv 的,tikv 的配置项大多数用 '-'。这会导致 同样配置脱敏行为,或者安全证书的时候,tiflash 的配置项设置显得有些不协调。

这个如果要做,需要 tiflash 配置项的解析代码做些兼容,不是只修改文档就可以的。

这样啊,谢谢解惑,不过看起来情况有些复杂了。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants