Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resource_control: add processed_keys and ru to runaway #18575

Merged
merged 10 commits into from
Oct 16, 2024
Merged

resource_control: add processed_keys and ru to runaway #18575

merged 10 commits into from
Oct 16, 2024

Conversation

HuSharp
Copy link
Contributor

@HuSharp HuSharp commented Sep 9, 2024 •
edited by lilin90
Loading

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v8.4 (TiDB 8.4 versions)
  • v8.3 (TiDB 8.3 versions)
  • v8.2 (TiDB 8.2 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@HuSharp
add more params
95c3088 
Signed-off-by: husharp <[email protected]>
@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 9, 2024
@Oreoxmt Oreoxmt requested review from lilin90 and removed request for Oreoxmt September 9, 2024 06:56
@Oreoxmt Oreoxmt added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. v8.4 This PR/issue applies to TiDB v8.4. translation/doing This PR’s assignee is translating this PR. labels Sep 9, 2024
@ti-chi-bot ti-chi-bot bot removed the missing-translation-status This PR does not have translation status info. label Sep 9, 2024
lilin90
lilin90 reviewed Sep 10, 2024
View reviewed changes
information-schema/information-schema-runaway-watches.md Outdated Show resolved Hide resolved
tidb-resource-control.md Outdated Show resolved Hide resolved
tidb-resource-control.md Outdated Show resolved Hide resolved
tidb-resource-control.md Outdated Show resolved Hide resolved
@lilin90 lilin90 changed the title runaway: Add processed_keys and request_ru to check *: add runaway processed_keys and request_ru to check Sep 10, 2024
@lilin90 lilin90 mentioned this pull request Sep 10, 2024
Merged
15 tasks
@lilin90 lilin90 changed the title *: add runaway processed_keys and request_ru to check *: add runaway processed_keys and request_unit to check Sep 10, 2024
@HuSharp HuSharp changed the title *: add runaway processed_keys and request_unit to check resource_control: add processed_keys and ru to runaway Sep 11, 2024
@HuSharp
add more cases
7bbfca3 
Signed-off-by: husharp <[email protected]>
glorv
glorv reviewed Sep 11, 2024
View reviewed changes
Copy link
Contributor

@glorv glorv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lilin90 lilin90 removed the translation/doing This PR’s assignee is translating this PR. label Sep 12, 2024
@lilin90 lilin90 added the translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. label Sep 12, 2024
lilin90
lilin90 approved these changes Sep 12, 2024
View reviewed changes
Copy link
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Sep 12, 2024
@lilin90 lilin90 requested a review from hfxsd September 12, 2024 08:28
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 14, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 14, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-09-12 08:18:06.386528799 +0000 UTC m=+517156.126952751: ☑️ agreed by lilin90.
  • 2024-09-14 01:24:20.010309557 +0000 UTC m=+665129.750733507: ☑️ agreed by hfxsd.

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 14, 2024

@nolouch: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

lilin90
lilin90 reviewed Oct 16, 2024
View reviewed changes
Copy link
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lilin90

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Oct 16, 2024
@lilin90
Copy link
Member

lilin90 commented Oct 16, 2024

/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 16, 2024
@lilin90 lilin90 added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 16, 2024
@lilin90
Copy link
Member

lilin90 commented Oct 16, 2024

/hold

lilin90
lilin90 reviewed Oct 16, 2024
View reviewed changes
tidb-resource-control.md Outdated Show resolved Hide resolved
@lilin90
Copy link
Member

lilin90 commented Oct 16, 2024

/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 16, 2024
@ti-chi-bot ti-chi-bot bot merged commit d1ea268 into pingcap:master Oct 16, 2024
7 checks passed
@HuSharp HuSharp deleted the add_more_param_in_runaway branch October 16, 2024 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lilin90 lilin90 lilin90 approved these changes

@glorv glorv glorv left review comments

@hfxsd hfxsd hfxsd approved these changes

@nolouch nolouch nolouch approved these changes

@JmPotato JmPotato Awaiting requested review from JmPotato

Assignees

@lilin90 lilin90

Labels
approved lgtm size/L Denotes a PR that changes 100-499 lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. v8.4 This PR/issue applies to TiDB v8.4.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@HuSharp @lilin90 @glorv @nolouch @hfxsd @Oreoxmt