Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: add variables for instance plan cache #18557

Merged
merged 18 commits into from
Oct 15, 2024
Merged

planner: add variables for instance plan cache #18557

merged 18 commits into from
Oct 15, 2024

Conversation

qw4990
Copy link
Contributor

@qw4990 qw4990 commented Sep 6, 2024 •
edited
Loading

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v8.4 (TiDB 8.4 versions)
  • v8.3 (TiDB 8.3 versions)
  • v8.2 (TiDB 8.2 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions))

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 6, 2024
@Oreoxmt Oreoxmt self-assigned this Sep 9, 2024
@Oreoxmt Oreoxmt added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. area/planner Indicates that the Issue or PR belongs to the area of SQL planner or optimizer. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. v8.4 This PR/issue applies to TiDB v8.4. labels Sep 9, 2024
time-and-fate
time-and-fate approved these changes Sep 9, 2024
View reviewed changes
system-variables.md Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 9, 2024

@time-and-fate: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

qw4990
qw4990 commented Sep 9, 2024
View reviewed changes
system-variables.md Outdated Show resolved Hide resolved
@Oreoxmt Oreoxmt added the translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. label Sep 10, 2024
@ti-chi-bot ti-chi-bot bot removed the missing-translation-status This PR does not have translation status info. label Sep 10, 2024
@Oreoxmt
fix format
14892d6 
Signed-off-by: Aolin <[email protected]>
Oreoxmt
Oreoxmt reviewed Sep 12, 2024
View reviewed changes
system-variables.md Outdated Show resolved Hide resolved
Oreoxmt
Oreoxmt reviewed Sep 12, 2024
View reviewed changes
system-variables.md Outdated Show resolved Hide resolved
Oreoxmt
Oreoxmt reviewed Sep 12, 2024
View reviewed changes
system-variables.md Outdated Show resolved Hide resolved
@Oreoxmt Oreoxmt mentioned this pull request Sep 12, 2024
Merged
16 tasks
@songrijie
Copy link
Contributor

这3个变量要说明下单位是“字节”。

qw4990
qw4990 commented Sep 13, 2024
View reviewed changes
system-variables.md Outdated Show resolved Hide resolved
qw4990
qw4990 commented Sep 13, 2024
View reviewed changes
system-variables.md Outdated Show resolved Hide resolved
songrijie
songrijie reviewed Sep 15, 2024
View reviewed changes
system-variables.md Outdated Show resolved Hide resolved
songrijie
songrijie reviewed Sep 15, 2024
View reviewed changes
system-variables.md Outdated Show resolved Hide resolved
songrijie
songrijie reviewed Sep 15, 2024
View reviewed changes
system-variables.md Outdated Show resolved Hide resolved
qw4990 and others added 3 commits September 18, 2024 09:22
Oreoxmt
Oreoxmt reviewed Sep 18, 2024
View reviewed changes
system-variables.md Outdated Show resolved Hide resolved
Oreoxmt
Oreoxmt reviewed Sep 18, 2024
View reviewed changes
system-variables.md Outdated Show resolved Hide resolved
Oreoxmt
Oreoxmt reviewed Sep 18, 2024
View reviewed changes
system-variables.md Outdated Show resolved Hide resolved
Oreoxmt
Oreoxmt reviewed Sep 18, 2024
View reviewed changes
system-variables.md Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Sep 19, 2024
Oreoxmt
Oreoxmt reviewed Sep 19, 2024
View reviewed changes
system-variables.md Outdated Show resolved Hide resolved
qiancai
qiancai approved these changes Sep 20, 2024
View reviewed changes
Copy link
Collaborator

@qiancai qiancai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

system-variables.md Outdated Show resolved Hide resolved
system-variables.md Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 20, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 20, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-09-19 07:48:51.389539829 +0000 UTC m=+1120201.129963770: ☑️ agreed by Oreoxmt.
  • 2024-09-20 04:05:18.704121859 +0000 UTC m=+1193188.444545798: ☑️ agreed by qiancai.

@Oreoxmt
Copy link
Collaborator

Oreoxmt commented Oct 15, 2024

/approve
/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 15, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Oreoxmt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Oct 15, 2024
@ti-chi-bot ti-chi-bot bot merged commit 858a9d0 into pingcap:master Oct 15, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Oreoxmt Oreoxmt Oreoxmt approved these changes

@qiancai qiancai qiancai approved these changes

@time-and-fate time-and-fate time-and-fate approved these changes

@songrijie songrijie Awaiting requested review from songrijie

Assignees

@Oreoxmt Oreoxmt

Labels
approved area/planner Indicates that the Issue or PR belongs to the area of SQL planner or optimizer. lgtm size/M Denotes a PR that changes 30-99 lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. v8.4 This PR/issue applies to TiDB v8.4.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@qw4990 @songrijie @Oreoxmt @time-and-fate @qiancai