From 5d53234e10872d34c171ab7387e56abe93c1f477 Mon Sep 17 00:00:00 2001 From: jinshayumi <791682161@QQ.COM> Date: Fri, 6 Sep 2024 15:00:26 +0800 Subject: [PATCH 1/6] Update tiflash-configuration.md --- tiflash/tiflash-configuration.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/tiflash/tiflash-configuration.md b/tiflash/tiflash-configuration.md index af690624184a1..0f101144b8ebb 100644 --- a/tiflash/tiflash-configuration.md +++ b/tiflash/tiflash-configuration.md @@ -207,6 +207,10 @@ delta_index_cache_size = 0 ## see known issue [#5576](https://github.com/pingcap/tiflash/issues/5576). # dt_enable_logical_split = false + ## `max_threads`: The default value is the number of CPU cores. This parameter + ## is the maximum number of threads executed. This parameter only takes effect + ## when the system variable `tidb_max_tiflash_threads` is set to -1. + ## The memory usage limit for the generated intermediate data in a single query. ## When the value is an integer, the unit is byte. For example, 34359738368 means 32 GiB of memory limit, and 0 means no limit. ## When the value is a floating-point number in the range of [0.0, 1.0), it means the ratio of the allowed memory usage to the total memory of the node. For example, 0.8 means 80% of the total memory, and 0.0 means no limit. From 6fd8104bbe4bdaae3ef55ededd5e3c46965c4dc2 Mon Sep 17 00:00:00 2001 From: xixirangrang Date: Fri, 6 Sep 2024 17:24:26 +0800 Subject: [PATCH 2/6] Update tiflash/tiflash-configuration.md --- tiflash/tiflash-configuration.md | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tiflash/tiflash-configuration.md b/tiflash/tiflash-configuration.md index 0f101144b8ebb..31965282c7f32 100644 --- a/tiflash/tiflash-configuration.md +++ b/tiflash/tiflash-configuration.md @@ -210,7 +210,9 @@ delta_index_cache_size = 0 ## `max_threads`: The default value is the number of CPU cores. This parameter ## is the maximum number of threads executed. This parameter only takes effect ## when the system variable `tidb_max_tiflash_threads` is set to -1. - + ## For example, if the number of CPU cores is 32, you can set the parameter as follows: + max_threads = 32 + ## The memory usage limit for the generated intermediate data in a single query. ## When the value is an integer, the unit is byte. For example, 34359738368 means 32 GiB of memory limit, and 0 means no limit. ## When the value is a floating-point number in the range of [0.0, 1.0), it means the ratio of the allowed memory usage to the total memory of the node. For example, 0.8 means 80% of the total memory, and 0.0 means no limit. From ca6423f073b4eb035cab8bfb7aec4e050d24f955 Mon Sep 17 00:00:00 2001 From: jinshayumi <791682161@QQ.COM> Date: Fri, 6 Sep 2024 18:18:12 +0800 Subject: [PATCH 3/6] Update tiflash-configuration.md --- tiflash/tiflash-configuration.md | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tiflash/tiflash-configuration.md b/tiflash/tiflash-configuration.md index 31965282c7f32..39be9cdffca84 100644 --- a/tiflash/tiflash-configuration.md +++ b/tiflash/tiflash-configuration.md @@ -207,11 +207,11 @@ delta_index_cache_size = 0 ## see known issue [#5576](https://github.com/pingcap/tiflash/issues/5576). # dt_enable_logical_split = false - ## `max_threads`: The default value is the number of CPU cores. This parameter - ## is the maximum number of threads executed. This parameter only takes effect + ## `max_threads`: The default value is 0 and when it is set to 0, + ## TiFlash will use the number of cpu cores as the execute concurrency. + ## This parameter only takes effect ## when the system variable `tidb_max_tiflash_threads` is set to -1. - ## For example, if the number of CPU cores is 32, you can set the parameter as follows: - max_threads = 32 + max_threads = 0 ## The memory usage limit for the generated intermediate data in a single query. ## When the value is an integer, the unit is byte. For example, 34359738368 means 32 GiB of memory limit, and 0 means no limit. From 57bf9f59d23420ed821b18d4f07b504683a3f8d4 Mon Sep 17 00:00:00 2001 From: jinshayumi <791682161@QQ.COM> Date: Fri, 6 Sep 2024 18:19:49 +0800 Subject: [PATCH 4/6] Update tiflash-configuration.md --- tiflash/tiflash-configuration.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tiflash/tiflash-configuration.md b/tiflash/tiflash-configuration.md index 39be9cdffca84..c17b0d8de47a5 100644 --- a/tiflash/tiflash-configuration.md +++ b/tiflash/tiflash-configuration.md @@ -207,7 +207,8 @@ delta_index_cache_size = 0 ## see known issue [#5576](https://github.com/pingcap/tiflash/issues/5576). # dt_enable_logical_split = false - ## `max_threads`: The default value is 0 and when it is set to 0, + ## `max_threads`: The internal execute concurrency when TiFlash execute a MPP task. + ## The default value is 0 and when it is set to 0, ## TiFlash will use the number of cpu cores as the execute concurrency. ## This parameter only takes effect ## when the system variable `tidb_max_tiflash_threads` is set to -1. From 95d8febaf85baf35ed3ee169cffed27b393a42d5 Mon Sep 17 00:00:00 2001 From: xixirangrang Date: Fri, 6 Sep 2024 18:26:31 +0800 Subject: [PATCH 5/6] Update tiflash/tiflash-configuration.md --- tiflash/tiflash-configuration.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tiflash/tiflash-configuration.md b/tiflash/tiflash-configuration.md index c17b0d8de47a5..aff651ef7b060 100644 --- a/tiflash/tiflash-configuration.md +++ b/tiflash/tiflash-configuration.md @@ -207,9 +207,9 @@ delta_index_cache_size = 0 ## see known issue [#5576](https://github.com/pingcap/tiflash/issues/5576). # dt_enable_logical_split = false - ## `max_threads`: The internal execute concurrency when TiFlash execute a MPP task. - ## The default value is 0 and when it is set to 0, - ## TiFlash will use the number of cpu cores as the execute concurrency. + ## `max_threads`: The internal execution concurrency when TiFlash executes an MPP task. + ## The default value is 0. When it is set to 0, + ## TiFlash uses the number of CPU cores as the execution concurrency. ## This parameter only takes effect ## when the system variable `tidb_max_tiflash_threads` is set to -1. max_threads = 0 From dc90dd8aff9a0c20853bdd781c7247d9de6cc1c4 Mon Sep 17 00:00:00 2001 From: xixirangrang Date: Mon, 9 Sep 2024 10:22:12 +0800 Subject: [PATCH 6/6] Update tiflash/tiflash-configuration.md Co-authored-by: Lilian Lee --- tiflash/tiflash-configuration.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tiflash/tiflash-configuration.md b/tiflash/tiflash-configuration.md index aff651ef7b060..459a0e1f75768 100644 --- a/tiflash/tiflash-configuration.md +++ b/tiflash/tiflash-configuration.md @@ -207,7 +207,7 @@ delta_index_cache_size = 0 ## see known issue [#5576](https://github.com/pingcap/tiflash/issues/5576). # dt_enable_logical_split = false - ## `max_threads`: The internal execution concurrency when TiFlash executes an MPP task. + ## `max_threads` indicates the internal thread concurrency when TiFlash executes an MPP task. ## The default value is 0. When it is set to 0, ## TiFlash uses the number of CPU cores as the execution concurrency. ## This parameter only takes effect