Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update optimizer-fix-controls.md #19515

Merged
merged 3 commits into from
Dec 5, 2024
Merged

Update optimizer-fix-controls.md #19515

merged 3 commits into from
Dec 5, 2024

Conversation

ghazalfamilyusa
Copy link
Contributor

@ghazalfamilyusa ghazalfamilyusa commented Nov 27, 2024 •
edited by lilin90
Loading

First-time contributors' checklist

What is changed, added or deleted? (Required)

Adds pingcap/tidb#54337 to Optimizer Fix Controls | TiDB Docs

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v8.5 (TiDB 8.5 versions)
  • v8.4 (TiDB 8.4 versions)
  • v8.3 (TiDB 8.3 versions)
  • v8.2 (TiDB 8.2 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot bot added first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 27, 2024
@lilin90 lilin90 requested a review from fixdb November 28, 2024 04:02
@lilin90 lilin90 added the translation/doing This PR's assignee is translating this PR. label Nov 28, 2024
@ti-chi-bot ti-chi-bot bot removed the missing-translation-status This PR does not have translation status info. label Nov 28, 2024
@lilin90 lilin90 self-assigned this Nov 28, 2024
fixdb
fixdb approved these changes Nov 28, 2024
View reviewed changes
Copy link
Contributor

@fixdb fixdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

optimizer-fix-controls.md Outdated

- Default value: `OFF`
- Possible values: `ON`, `OFF`
- Currently, TiDB optimizer has limitations in deriving index ranges for complex conjunctive conditions where each conjunct comprises a list of ranges. This be addressed by applying general range intersection.
Copy link
Contributor

@fixdb fixdb Nov 28, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This be -> This will be or This is

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 28, 2024

@fixdb: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 28, 2024

@qw4990: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@lilin90 lilin90 added needs-cherry-pick-release-8.2 Should cherry pick this PR to release-8.2 branch. needs-cherry-pick-release-8.3 Should cherry pick this PR to release-8.3 branch. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. needs-cherry-pick-release-8.4 Should cherry pick this PR to release-8.4 branch. labels Dec 5, 2024
lilin90
lilin90 reviewed Dec 5, 2024
View reviewed changes
optimizer-fix-controls.md Outdated Show resolved Hide resolved
optimizer-fix-controls.md Outdated Show resolved Hide resolved
lilin90
lilin90 reviewed Dec 5, 2024
View reviewed changes
optimizer-fix-controls.md Outdated Show resolved Hide resolved
@lilin90 lilin90 mentioned this pull request Dec 5, 2024
Merged
16 tasks
@lilin90 lilin90 requested a review from hfxsd December 5, 2024 08:18
@lilin90 lilin90 added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR's assignee is translating this PR. labels Dec 5, 2024
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Dec 5, 2024
lilin90
lilin90 approved these changes Dec 5, 2024
View reviewed changes
Copy link
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 5, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 5, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-12-05 08:36:36.089043729 +0000 UTC m=+1316783.708698245: ☑️ agreed by hfxsd.
  • 2024-12-05 08:38:46.459983794 +0000 UTC m=+1316914.079638310: ☑️ agreed by lilin90.

@hfxsd
Copy link
Collaborator

hfxsd commented Dec 5, 2024

/approve

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hfxsd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Dec 5, 2024
@ti-chi-bot ti-chi-bot bot merged commit f7979b6 into master Dec 5, 2024
9 checks passed
@ti-chi-bot ti-chi-bot mentioned this pull request Dec 5, 2024
Merged
16 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.4: #19589.

This was referenced Dec 5, 2024
Merged
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.2: #19590.

This was referenced Dec 5, 2024
Merged
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.3: #19591.

This was referenced Dec 5, 2024
Merged
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.5: #19592.

@ti-chi-bot ti-chi-bot mentioned this pull request Dec 5, 2024
Merged
17 tasks
ti-chi-bot bot pushed a commit that referenced this pull request Dec 5, 2024
@ti-chi-bot
Update optimizer-fix-controls.md (#19515) (#19589)
453861f
@lilin90 lilin90 deleted the ghazalfamilyusa-patch-1 branch December 5, 2024 09:05
ti-chi-bot bot pushed a commit that referenced this pull request Dec 5, 2024
@ti-chi-bot
Update optimizer-fix-controls.md (#19515) (#19590)
7496660
ti-chi-bot bot pushed a commit that referenced this pull request Dec 5, 2024
@ti-chi-bot
Update optimizer-fix-controls.md (#19515) (#19591)
5295baa
ti-chi-bot bot pushed a commit that referenced this pull request Dec 5, 2024
@ti-chi-bot
Update optimizer-fix-controls.md (#19515) (#19592)
6cf41dd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hfxsd hfxsd hfxsd approved these changes

@lilin90 lilin90 lilin90 approved these changes

@qw4990 qw4990 qw4990 approved these changes

@fixdb fixdb fixdb approved these changes

Assignees

@lilin90 lilin90

Labels
approved first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. lgtm needs-cherry-pick-release-8.2 Should cherry pick this PR to release-8.2 branch. needs-cherry-pick-release-8.3 Should cherry pick this PR to release-8.3 branch. needs-cherry-pick-release-8.4 Should cherry pick this PR to release-8.4 branch. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ghazalfamilyusa @hfxsd @ti-chi-bot @fixdb @qw4990 @lilin90