Skip to content

Commit

Permalink
deploy: 6370c64
Browse files Browse the repository at this point in the history
  • Loading branch information
zhangyangyu committed Aug 2, 2023
1 parent c01a86f commit 33d5695
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 6 deletions.
5 changes: 3 additions & 2 deletions contribute-to-tidb/review-a-pr.html
Original file line number Diff line number Diff line change
Expand Up @@ -204,8 +204,9 @@ <h2 id="writing-code-review-comments"><a class="header" href="#writing-code-revi
<li><strong>Provide additional details and context of your review process</strong>. Instead of simply &quot;approving&quot; the pull request. If your test the pull request, report the result and your test environment details. If you request changes, try to suggest how.</li>
</ul>
<h2 id="accepting-pull-requests"><a class="header" href="#accepting-pull-requests">Accepting pull requests</a></h2>
<p>Once you think the pull request is ready, you can <a href="https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/approving-a-pull-request-with-required-reviews">approve</a> it. </p>
<p>In the TiDB community, most repositories require two approvals before a pull request can be accepted. A few repositories require a different number of approvals, but two approvals are the default setting. After the required approval number is met, a committer can <a href="https://prow.tidb.io/command-help?repo=pingcap%2Ftidb#merge">/merge</a> the pull request.</p>
<p>Once you think the pull request is ready, you can <a href="https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/approving-a-pull-request-with-required-reviews">approve</a> it, commenting with <code>/lgtm</code> is also valid.</p>
<p>In the TiDB community, most repositories require two approvals before a pull request can be accepted. A few repositories require a different number of approvals, but two approvals are the default setting. After the required <code>lgtm</code> count is met, <code>lgtm</code> label will be added.
Finally committer can <a href="https://prow.tidb.io/command-help?repo=pingcap%2Ftidb#merge">/approve</a> the pull request, some special scopes need <code>/approve</code> by the scope approvers(define in <code>OWNERS</code> files).</p>

</main>

Expand Down
5 changes: 3 additions & 2 deletions print.html
Original file line number Diff line number Diff line change
Expand Up @@ -1224,8 +1224,9 @@ <h2 id="writing-code-review-comments"><a class="header" href="#writing-code-revi
<li><strong>Provide additional details and context of your review process</strong>. Instead of simply &quot;approving&quot; the pull request. If your test the pull request, report the result and your test environment details. If you request changes, try to suggest how.</li>
</ul>
<h2 id="accepting-pull-requests"><a class="header" href="#accepting-pull-requests">Accepting pull requests</a></h2>
<p>Once you think the pull request is ready, you can <a href="https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/approving-a-pull-request-with-required-reviews">approve</a> it. </p>
<p>In the TiDB community, most repositories require two approvals before a pull request can be accepted. A few repositories require a different number of approvals, but two approvals are the default setting. After the required approval number is met, a committer can <a href="https://prow.tidb.io/command-help?repo=pingcap%2Ftidb#merge">/merge</a> the pull request.</p>
<p>Once you think the pull request is ready, you can <a href="https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/approving-a-pull-request-with-required-reviews">approve</a> it, commenting with <code>/lgtm</code> is also valid.</p>
<p>In the TiDB community, most repositories require two approvals before a pull request can be accepted. A few repositories require a different number of approvals, but two approvals are the default setting. After the required <code>lgtm</code> count is met, <code>lgtm</code> label will be added.
Finally committer can <a href="https://prow.tidb.io/command-help?repo=pingcap%2Ftidb#merge">/approve</a> the pull request, some special scopes need <code>/approve</code> by the scope approvers(define in <code>OWNERS</code> files).</p>
<div style="break-before: page; page-break-before: always;"></div><h1 id="make-a-proposal"><a class="header" href="#make-a-proposal">Make a Proposal</a></h1>
<p>This page defines the best practices procedure for making a proposal in TiDB projects. This text is based on the content of <a href="https://github.com/pingcap/tidb/blob/7f4f5c02364b6578da561ec14f409a39ddf954a5/docs/design/README.md">TiDB Design Document</a>.</p>
<h2 id="motivation"><a class="header" href="#motivation">Motivation</a></h2>
Expand Down
2 changes: 1 addition & 1 deletion searchindex.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion searchindex.json

Large diffs are not rendered by default.

0 comments on commit 33d5695

Please sign in to comment.