Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kvclient(ticdc): add table id to kv client logs #11622

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

3AceShowHand
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #11621

What is changed and how it works?

  • add table id to kv client logs, so we can know the region corresponding table

Check List

Tests

  • Unit test
  • Integration test

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

`None`.

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-triage-completed release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 24, 2024
@3AceShowHand
Copy link
Contributor Author

/check-issue-triage-complete

Copy link

codecov bot commented Sep 24, 2024

Codecov Report

Attention: Patch coverage is 12.22222% with 79 lines in your changes missing coverage. Please review.

Project coverage is 57.4704%. Comparing base (25676cf) to head (0dd9516).
Report is 1 commits behind head on master.

Additional details and impacted files
Components Coverage Δ
cdc 61.1904% <12.2222%> (-0.0552%) ⬇️
dm 51.0625% <100.0000%> (+0.0069%) ⬆️
engine 63.4303% <ø> (+0.0353%) ⬆️
Flag Coverage Δ
unit 57.4704% <12.2222%> (-0.0206%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master     #11622        +/-   ##
================================================
- Coverage   57.4909%   57.4704%   -0.0206%     
================================================
  Files           851        851                
  Lines        126486     126512        +26     
================================================
- Hits          72718      72707        -11     
- Misses        48377      48415        +38     
+ Partials       5391       5390         -1     

Copy link
Contributor

ti-chi-bot bot commented Sep 24, 2024

@3AceShowHand: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cdc-integration-mysql-test 0dd9516 link true /test cdc-integration-mysql-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Contributor

ti-chi-bot bot commented Sep 24, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sdojjy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Sep 24, 2024
Copy link
Contributor

ti-chi-bot bot commented Sep 24, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-09-24 11:18:40.700953623 +0000 UTC m=+1564790.441377561: ☑️ agreed by sdojjy.

@ti-chi-bot ti-chi-bot bot added the approved label Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add table id to the kv client logs to make it more clear
2 participants