Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

puller: fix a bug that may cause error when replicate truncate table ddl #11772

Merged
merged 4 commits into from
Dec 5, 2024

Conversation

asddongmen
Copy link
Contributor

@asddongmen asddongmen commented Nov 19, 2024

What problem does this PR solve?

Issue Number: close #11765

What is changed and how it works?

Check List

Tests

  • Unit test
  • Manual test (add detailed scripts or steps below)

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

Fix a bug that may cause error when encounter a  truncate table DDL of a ineligible table.

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 19, 2024
@asddongmen asddongmen marked this pull request as draft November 19, 2024 03:29
@ti-chi-bot ti-chi-bot bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 19, 2024
@asddongmen
Copy link
Contributor Author

/test all

Copy link

codecov bot commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.1708%. Comparing base (6fc5a49) to head (ecd1a3a).
Report is 47 commits behind head on master.

Additional details and impacted files
Components Coverage Δ
cdc 59.5992% <100.0000%> (-1.6109%) ⬇️
dm 50.0654% <ø> (-0.9801%) ⬇️
engine 53.2167% <ø> (-10.1572%) ⬇️
Flag Coverage Δ
unit 55.1708% <100.0000%> (-2.2954%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master     #11772        +/-   ##
================================================
- Coverage   57.4662%   55.1708%   -2.2954%     
================================================
  Files           851       1002       +151     
  Lines        126462     137404     +10942     
================================================
+ Hits          72673      75807      +3134     
- Misses        48389      56056      +7667     
- Partials       5400       5541       +141     
---- 🚨 Try these New Features:

Signed-off-by: dongmen <[email protected]>
@asddongmen
Copy link
Contributor Author

/test all

@asddongmen asddongmen marked this pull request as ready for review December 2, 2024 03:56
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 2, 2024
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Dec 2, 2024
Signed-off-by: dongmen <[email protected]>
@asddongmen
Copy link
Contributor Author

/retest

Copy link
Contributor

ti-chi-bot bot commented Dec 2, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CharlesCheung96, lidezhu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [CharlesCheung96,lidezhu]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 2, 2024
Copy link
Contributor

ti-chi-bot bot commented Dec 2, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-12-02 06:12:37.900962291 +0000 UTC m=+1048945.520616806: ☑️ agreed by lidezhu.
  • 2024-12-02 09:00:45.505476433 +0000 UTC m=+1059033.125130946: ☑️ agreed by CharlesCheung96.

@asddongmen asddongmen added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Dec 2, 2024
@asddongmen
Copy link
Contributor Author

/retest

1 similar comment
@asddongmen
Copy link
Contributor Author

/retest

@ti-chi-bot ti-chi-bot bot merged commit 8439122 into pingcap:master Dec 5, 2024
26 checks passed
@ti-chi-bot ti-chi-bot bot added the needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. label Dec 9, 2024
@ti-chi-bot ti-chi-bot bot added needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. labels Dec 9, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #11847.

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Dec 9, 2024
ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Dec 9, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #11848.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #11849.

@ti-chi-bot ti-chi-bot bot added needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. and removed needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. labels Dec 9, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #11850.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.5: #11851.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

truncate table of ineligible table is not ignored
4 participants