Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consumer(ticdc): modify kafka consumer #11819

Merged
merged 6 commits into from
Dec 5, 2024
Merged

Conversation

wk989898
Copy link
Collaborator

@wk989898 wk989898 commented Dec 3, 2024

What problem does this PR solve?

Issue Number: close #11818

What is changed and how it works?

Delete event sorting and add debug logs

Check List

Tests

  • Unit test
  • Integration test

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

`None`.

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 3, 2024
Copy link

codecov bot commented Dec 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.1628%. Comparing base (cc2de37) to head (adcaabc).

✅ All tests successful. No failed tests found.

Additional details and impacted files
Components Coverage Δ
cdc 59.5917% <ø> (+0.0073%) ⬆️
dm 50.0509% <ø> (+0.0019%) ⬆️
engine 53.2279% <ø> (-0.0057%) ⬇️
Flag Coverage Δ
unit 55.1628% <ø> (+0.0036%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master     #11819        +/-   ##
================================================
+ Coverage   55.1592%   55.1628%   +0.0036%     
================================================
  Files          1003       1003                
  Lines        137462     137462                
================================================
+ Hits          75823      75828         +5     
+ Misses        56091      56088         -3     
+ Partials       5548       5546         -2     

@wk989898 wk989898 requested a review from 3AceShowHand December 3, 2024 03:14
@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 3, 2024
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Dec 5, 2024
Copy link
Contributor

ti-chi-bot bot commented Dec 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 3AceShowHand, CharlesCheung96

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [3AceShowHand,CharlesCheung96]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 5, 2024
Copy link
Contributor

ti-chi-bot bot commented Dec 5, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-12-05 06:03:24.922545298 +0000 UTC m=+1307592.542199815: ☑️ agreed by 3AceShowHand.
  • 2024-12-05 06:16:27.424585184 +0000 UTC m=+1308375.044239697: ☑️ agreed by CharlesCheung96.

@wk989898
Copy link
Collaborator Author

wk989898 commented Dec 5, 2024

/retest

5 similar comments
@3AceShowHand
Copy link
Contributor

/retest

@3AceShowHand
Copy link
Contributor

/retest

@3AceShowHand
Copy link
Contributor

/retest

@3AceShowHand
Copy link
Contributor

/retest

@3AceShowHand
Copy link
Contributor

/retest

@ti-chi-bot ti-chi-bot bot merged commit 4538839 into pingcap:master Dec 5, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

make kafka comsumer more robust
3 participants