Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net, backend: fix wrong format in error packet #357

Merged
merged 1 commit into from
Sep 4, 2023

Conversation

djshow832
Copy link
Collaborator

What problem does this PR solve?

Issue Number: close #356

Problem Summary:
Wrong format: ERROR 1105 (HY000): Unknown error%!(EXTRA string=Verify TiDB capability failed, please upgrade TiDB)

What is changed and how it works:

  • Use NewDefaultError and NewError in github.com/go-mysql-org/go-mysql/mysql because they handle both formatted and unformatted error messages.
  • Replace some constants from tidb/parser/mysql to proxy/net or github.com/go-mysql-org/go-mysql/mysql.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Notable changes

  • Has configuration change
  • Has HTTP API interfaces change
  • Has tiproxyctl change
  • Other user behavior changes

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@djshow832 djshow832 requested a review from xhebox September 4, 2023 08:40
@ti-chi-bot ti-chi-bot bot requested a review from bb7133 September 4, 2023 08:40
@ti-chi-bot ti-chi-bot bot added the size/L label Sep 4, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 4, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xhebox

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 4, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-09-04 09:02:56.142217688 +0000 UTC m=+2349740.691233674: ☑️ agreed by xhebox.

@ti-chi-bot ti-chi-bot bot merged commit 53a957f into pingcap:main Sep 4, 2023
6 checks passed
@djshow832 djshow832 deleted the fix_errmsg branch September 4, 2023 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong format in unknown error
2 participants