Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proxy, util: recover from connection panic #368

Merged
merged 1 commit into from
Sep 13, 2023

Conversation

djshow832
Copy link
Collaborator

What problem does this PR solve?

Issue Number: close #363

Problem Summary:
Previously, if a connection panics, the server quits. The server should still run.

What is changed and how it works:
Call recover() in defer in each connection to prevent the panic from passing to the server.
As for the common modules, such as the cert manager, router, logger manager, panic is critical, so it's better to let the server quit if they encounter errors.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Notable changes

  • Has configuration change
  • Has HTTP API interfaces change
  • Has tiproxyctl change
  • Other user behavior changes

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@djshow832 djshow832 requested a review from xhebox September 13, 2023 09:41
@ti-chi-bot ti-chi-bot bot requested a review from bb7133 September 13, 2023 09:41
@ti-chi-bot ti-chi-bot bot added the size/L label Sep 13, 2023
@ti-chi-bot ti-chi-bot bot added the lgtm label Sep 13, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 13, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xhebox

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 13, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-09-13 14:10:22.564048812 +0000 UTC m=+94588.531636858: ☑️ agreed by xhebox.

@ti-chi-bot ti-chi-bot bot added the approved label Sep 13, 2023
@ti-chi-bot ti-chi-bot bot merged commit 01f1152 into pingcap:main Sep 13, 2023
6 checks passed
@djshow832 djshow832 deleted the recover_panic branch September 14, 2023 01:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle panic in each connection to prevent server panic
2 participants