Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backend, net: replace tidb/parser/mysql #415

Merged
merged 3 commits into from
Dec 15, 2023
Merged

Conversation

djshow832
Copy link
Collaborator

What problem does this PR solve?

Issue Number: close #358

Problem Summary:
Using tidb/parser/mysql, go-mysql-org/go-mysql/mysql, and pnet at the same time may cause problems, such as errors.Is(err, mysql.ErrMalformPacket) may unexpectedly return false.

What is changed and how it works:

  • Add server_status.go
  • Replace most of the usage of tidb/parser/mysql with go-mysql-org/go-mysql/mysql and pnet

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code refactor, no tests.

Notable changes

  • Has configuration change
  • Has HTTP API interfaces change
  • Has tiproxyctl change
  • Other user behavior changes

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot requested review from bb7133 and xhebox December 15, 2023 07:10
@ti-chi-bot ti-chi-bot bot added the size/L label Dec 15, 2023
Copy link

ti-chi-bot bot commented Dec 15, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xhebox

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the lgtm label Dec 15, 2023
Copy link

ti-chi-bot bot commented Dec 15, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-12-15 12:36:08.446088662 +0000 UTC m=+618859.483315589: ☑️ agreed by xhebox.

@ti-chi-bot ti-chi-bot bot added the approved label Dec 15, 2023
@ti-chi-bot ti-chi-bot bot merged commit a5c94ca into pingcap:main Dec 15, 2023
9 checks passed
@djshow832 djshow832 deleted the malformed branch December 15, 2023 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace constants in tidb/parser to go-mysql.
2 participants