From 79fb8c801442dc0f54796145cc2ed5408d72bbe3 Mon Sep 17 00:00:00 2001 From: Yisheng Zhou Date: Mon, 12 Aug 2024 09:01:39 -0700 Subject: [PATCH] Update node recovery check timeout values --- .../pinterest/orion/core/actions/generic/NodeAction.java | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/orion-server/src/main/java/com/pinterest/orion/core/actions/generic/NodeAction.java b/orion-server/src/main/java/com/pinterest/orion/core/actions/generic/NodeAction.java index d79cf984..fafa3e61 100644 --- a/orion-server/src/main/java/com/pinterest/orion/core/actions/generic/NodeAction.java +++ b/orion-server/src/main/java/com/pinterest/orion/core/actions/generic/NodeAction.java @@ -30,6 +30,8 @@ public abstract class NodeAction extends Action { public static final String POSTHEALTHCHECK_INTERVAL = "postHealthcheckInterval"; public static final String RECOVERY_TIMEOUT = "recoveryTimeout"; + private static final int DEFAULT_RECOVERY_TIMEOUT_MS = 1800_000; // 30 minutes + private static final int DEFAULT_HEALTHCHECK_INTERVAL_MS = 10_000; // 10 seconds enum MaintenancePolicy { NONE, @@ -151,8 +153,8 @@ protected void postActionValidation() throws Exception { public void checkAndWaitForNodeToRecover() throws TimeoutException { long completeTime = System.currentTimeMillis(); - int timeout = 60_000; - int healthCheckInterval = 10_000; + int timeout = DEFAULT_RECOVERY_TIMEOUT_MS; + int healthCheckInterval = DEFAULT_HEALTHCHECK_INTERVAL_MS; if (containsAttribute(RECOVERY_TIMEOUT)) { timeout = getAttribute(RECOVERY_TIMEOUT).getValue(); }