From 5564383c11ebd4e6ec24814acabd74dbf7d330c7 Mon Sep 17 00:00:00 2001 From: Beto Dealmeida Date: Tue, 30 May 2023 12:18:20 -0700 Subject: [PATCH 1/2] fix: dashboard ownership check (#24249) --- superset-frontend/src/dashboard/util/permissionUtils.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/superset-frontend/src/dashboard/util/permissionUtils.ts b/superset-frontend/src/dashboard/util/permissionUtils.ts index 3ea63976bfdaa..6a218349b2f94 100644 --- a/superset-frontend/src/dashboard/util/permissionUtils.ts +++ b/superset-frontend/src/dashboard/util/permissionUtils.ts @@ -42,7 +42,7 @@ const isUserDashboardOwner = ( user: UserWithPermissionsAndRoles | UndefinedUser, ) => isUserWithPermissionsAndRoles(user) && - dashboard.owners.some(owner => owner.username === user.username); + dashboard.owners.some(owner => owner.id === user.userId); export const canUserEditDashboard = ( dashboard: Dashboard, From c3d57b08eadec4be5ad2817e52eb9e1ca813cc18 Mon Sep 17 00:00:00 2001 From: kgopal Date: Thu, 9 Nov 2023 16:24:22 -0800 Subject: [PATCH 2/2] Change dashboard standalone mode to fix report screenshot error --- superset/utils/screenshots.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/superset/utils/screenshots.py b/superset/utils/screenshots.py index a904b7dc4384a..70fe76552c643 100644 --- a/superset/utils/screenshots.py +++ b/superset/utils/screenshots.py @@ -236,7 +236,7 @@ def __init__( # should always capture in standalone url = modify_url_query( url, - standalone=DashboardStandaloneMode.REPORT.value, + standalone=DashboardStandaloneMode.HIDE_NAV_AND_TITLE.value, # TODO: temp fix for report mode error ) super().__init__(url, digest)