From fbb862b965f60bad1a975da30f98ce8bc82f9873 Mon Sep 17 00:00:00 2001
From: Jessica Chen <jessicac@pinterest.com>
Date: Mon, 4 Mar 2024 10:40:27 -0800
Subject: [PATCH] Migrate maven deploy to artifactory-push CLI (#1491)

* migrate to artifactory-push

* move plugins outside of pluginManagement

* cleanup

* remove settings.xml

* add comments

---------

Co-authored-by: Jessica Chen <jessicac@devrestricted-jessicac.ec2.pin220.com>
---
 deploy-service/pom.xml           | 13 ----------
 deploy-service/settings.xml      | 16 ------------
 deploy-service/universal/pom.xml | 43 ++++++++++++++++++++++++++++++++
 3 files changed, 43 insertions(+), 29 deletions(-)
 delete mode 100644 deploy-service/settings.xml

diff --git a/deploy-service/pom.xml b/deploy-service/pom.xml
index 12284f2a01..6d2fc23c80 100644
--- a/deploy-service/pom.xml
+++ b/deploy-service/pom.xml
@@ -106,19 +106,6 @@
         </plugins>
     </build>
 
-    <distributionManagement>
-        <repository>
-            <id>central</id>
-            <name>maven-releases</name>
-            <url>https://artifacts-prod-use1.pinadmin.com/artifactory/maven-private-prod-sox-local</url>
-        </repository>
-        <snapshotRepository>
-            <id>snapshots</id>
-            <name>maven-snapshots</name>
-            <url>https://artifacts-prod-use1.pinadmin.com/artifactory/maven-private-prod-sox-local</url>
-        </snapshotRepository>
-    </distributionManagement>
-
     <profiles>
         <profile>
             <id>coverage</id>
diff --git a/deploy-service/settings.xml b/deploy-service/settings.xml
deleted file mode 100644
index 8937cab3ca..0000000000
--- a/deploy-service/settings.xml
+++ /dev/null
@@ -1,16 +0,0 @@
-<?xml version="1.0" encoding="UTF-8"?>
-<settings xsi:schemaLocation="http://maven.apache.org/SETTINGS/1.1.0 http://maven.apache.org/xsd/settings-1.1.0.xsd" xmlns="http://maven.apache.org/SETTINGS/1.1.0"
-    xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance">
-  <servers>
-    <server>
-      <username>${ARTIFACTORY_USER}</username>
-      <password>${ARTIFACTORY_TOKEN}</password>
-      <id>central</id>
-    </server>
-    <server>
-      <username>${ARTIFACTORY_USER}</username>
-      <password>${ARTIFACTORY_TOKEN}</password>
-      <id>snapshots</id>
-    </server>
-  </servers>
-</settings>
diff --git a/deploy-service/universal/pom.xml b/deploy-service/universal/pom.xml
index ff15487d85..e0da90ffa2 100644
--- a/deploy-service/universal/pom.xml
+++ b/deploy-service/universal/pom.xml
@@ -144,6 +144,9 @@
         <plugin>
           <artifactId>maven-deploy-plugin</artifactId>
           <version>2.8.2</version>
+          <configuration>  
+            <skip>true</skip>  
+          </configuration>
         </plugin>
         <plugin>
           <artifactId>maven-project-info-reports-plugin</artifactId>
@@ -164,6 +167,46 @@
           </execution>
         </executions>
       </plugin>
+      <plugin>
+        <!-- This is Pinterest deployment specific. -->
+        <!-- For non-Pinterest deployments, remove this block and use the maven-deploy-plugin instead. -->
+        <groupId>org.codehaus.mojo</groupId>
+        <artifactId>exec-maven-plugin</artifactId>
+        <version>3.0.0</version>  
+        <executions>
+          <execution>
+            <id>artifactory-push-deploy</id>
+            <phase>deploy</phase>
+            <goals>
+              <goal>exec</goal>
+            </goals>
+            <configuration>
+              <executable>artifactory-push</executable>
+              <arguments>
+                <argument>maven</argument>
+                <argument>--env</argument>
+                <argument>prod</argument>
+                <argument>--maven_type</argument>
+                <argument>${deployment.type}</argument>
+                <argument>--maven_group_id</argument>
+                <argument>${project.groupId}</argument>
+                <argument>--maven_artifact_id</argument>
+                <argument>${project.artifactId}</argument>
+                <argument>--maven_version</argument>
+                <argument>${project.version}</argument>
+                <argument>--maven_pom</argument>
+                <argument>${project.file.path}</argument>
+                <argument>--maven_jar</argument>
+                <argument>${project.build.directory}/${project.build.finalName}.jar</argument>
+                <argument>--maven_jar_src</argument>
+                <argument>${project.build.directory}/${project.build.finalName}-sources.jar</argument>
+                <argument>--to_repo</argument>
+                <argument>maven-private-prod-sox-local</argument>
+              </arguments>
+            </configuration>
+          </execution>
+        </executions>
+      </plugin>
     </plugins>
   </build>
 </project>
\ No newline at end of file