Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xy-VSFilter builds based on xy_sub_filter_rc* might be buggy #38

Open
TheOneric opened this issue Jan 5, 2023 · 3 comments
Open

xy-VSFilter builds based on xy_sub_filter_rc* might be buggy #38

TheOneric opened this issue Jan 5, 2023 · 3 comments

Comments

@TheOneric
Copy link
Contributor

Just to let you know, haven't checked if you already identified and fixed any such rendering issues:

In Cyberbeing/xy-VSFilter#18 Cyberbeing mentioned there are differences between upstream’s xy_sub_filter_rc* XySubFilter branches and the ones intended for xy-VSFilter and xy-VSFilter binaries based on the XySubFilter branches might be buggy. See Cyberbeing/xy-VSFilter#18 (comment) and follow-ups.

On a cursory glance it appears like you are using the XySubFilter branch for both XySubFilter and xy-VSFilter builds. At least your builds are not containing upstream’s CSRI name change from 2014 which was only committed to the xy-VSFilter branch: Cyberbeing/xy-VSFilter@0d64ad7 (released in 3.0.0.306)

@NBruderman
Copy link

@pinterf can you push that commit, just so the branches sync up?

@TheOneric
Copy link
Contributor Author

push that commit, just so the branches sync up?

There are supposedly more differences between Cyberbeing’s master (xy-VSFilter) and xy_sub_filter_rc* (XySubFilter) branches. Whether pinterf already merged all other fixes I do no know. If not, pulling in just the name change is a start but not a full solution.

@NBruderman
Copy link

Yeah, I agree... I guess the solution is either waiting for pinterf to check and merge the missing patches, or going yourself and checking the differences, and finding what changes weren't merged...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants