Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

64-bit timestamps #9

Open
slydiman opened this issue May 12, 2019 · 4 comments
Open

64-bit timestamps #9

slydiman opened this issue May 12, 2019 · 4 comments

Comments

@slydiman
Copy link
Contributor

Hello
k-lite codec pack uses your xy-VSFilter since v14.8.4 instead of VSFilter from mpc-hc.
But your xy-VSFilter uses 32-bit timestamps internally and lose timestamps in case of very long streams.
Please apply the following patch
mpc-hc/mpc-hc@04f914f
Thanks

@pinterf
Copy link
Owner

pinterf commented May 13, 2019

Thanks for the link. I'll do that, it does not require deep knowledge of project history :)

@slydiman
Copy link
Contributor Author

Thank you very much.

@pinterf
Copy link
Owner

pinterf commented Mar 6, 2021

Hi, time goes on, but thing are not forgotten. The patch could not be applied as-is, the files are so much different that VS wanted to delete the affected files :) instead of merge during the cherry pick. So I went through the differences manually. Then I'm gonna amend the commit to put you back as author.
A question: exactly how long is a 'very long stream' in the 32 bit world?

@clsid2
Copy link
Contributor

clsid2 commented Mar 6, 2021

In this case is ~596 hours I think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants