From 882e1d01cc88b2dfcc634cef46eabe3f79330ea1 Mon Sep 17 00:00:00 2001 From: pabloFuente Date: Thu, 16 Jan 2025 13:01:53 +0100 Subject: [PATCH] Close answer and assert errors in detach tests --- datachannel_go_test.go | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/datachannel_go_test.go b/datachannel_go_test.go index af829cf3192..bee388f09f4 100644 --- a/datachannel_go_test.go +++ b/datachannel_go_test.go @@ -826,22 +826,26 @@ func TestDataChannelClose(t *testing.T) { func TestDataChannel_DetachErrors(t *testing.T) { t.Run("error errDetachNotEnabled", func(t *testing.T) { s := SettingEngine{} - offer, _, _ := NewAPI(WithSettingEngine(s)).newPair(Configuration{}) + offer, answer, err := NewAPI(WithSettingEngine(s)).newPair(Configuration{}) + assert.NoError(t, err) dc, err := offer.CreateDataChannel("data", nil) assert.NoError(t, err) _, err = dc.Detach() assert.ErrorIs(t, err, errDetachNotEnabled) assert.NoError(t, offer.Close()) + assert.NoError(t, answer.Close()) }) t.Run("error errDetachBeforeOpened", func(t *testing.T) { s := SettingEngine{} s.DetachDataChannels() - offer, _, _ := NewAPI(WithSettingEngine(s)).newPair(Configuration{}) + offer, answer, err := NewAPI(WithSettingEngine(s)).newPair(Configuration{}) + assert.NoError(t, err) dc, err := offer.CreateDataChannel("data", nil) assert.NoError(t, err) _, err = dc.Detach() assert.ErrorIs(t, err, errDetachBeforeOpened) assert.NoError(t, offer.Close()) + assert.NoError(t, answer.Close()) }) }