introduction of mocking on "Functions should only be one level of abstraction" should be removed

[xMarkusx]

https://github.com/jupeter/clean-code-php#functions-should-only-be-one-level-of-abstraction

I think your refactoring results in two helper-classes "Lexer" and "Tokenizer". These types of classes should not be mocked nor handled by the di-framework.

Uncle Bob suggests to

Mock across architecturally significant boundaries, but not within those boundaries.

http://blog.cleancoder.com/uncle-bob/2014/05/10/WhenToMock.html

[peter-gribanov]

@xMarkusx please explain, i not understood you.
Did i do wrong by taking Lexer and Tokenizer to dependances?

If i leave Lexer and Tokenizer inside of BetterJSAlternative, i can't re-use them for other purposes or another language.

[xMarkusx]

No there is nothing wrong with the refactoring. Maybe this example is to abstract as i don't fully understand what Lexer, Tokenizer and BetterJSAlternative are supposed to do.

Since this is unclear, i would simply remove the last sentence
"Now we can mock the dependencies and test only the work of method BetterJSAlternative::parse()."
It could be better to mock them but it could be also correct to test them indirect through the parse function of BetterJSAlternative. It depends on the implementation of Lexer and Tokenizer.

Maybe the topic unit testing and mocking should be handled in a separate section where we can go more into detail when and how to mock?

[peter-gribanov]

I also do not understand the purpose of the parseBetterJSAlternative() function.
I made a guess from the context. Maybe i was wrong.

In one thing, i agree with you. The example is too complex and not obvious.

We need to think about the best example.

[ranggakd]

please closed this once it is solved already @xMarkusx @peter-gribanov
thank you 🙏