Prioritize unhealthy over unknown

Signed-off-by: Yoshiki Fujikane <[email protected]>
pipe-cd · Dec 26, 2024 · b723484 · b723484
1 parent 8e16586
commit b723484
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 0 deletions.
diff --git a/pkg/model/application_live_state.go b/pkg/model/application_live_state.go
@@ -157,11 +157,14 @@ func (s *ApplicationLiveStateSnapshot) DetermineApplicationHealthStatus() {
 			s.HealthStatus = ApplicationLiveStateSnapshot_UNHEALTHY
 			return
 		}
+	}
 
+	for _, r := range app.Resources {
 		if r.HealthStatus == ResourceState_UNKNOWN {
 			s.HealthStatus = ApplicationLiveStateSnapshot_UNKNOWN
 			return
 		}
 	}
+
 	s.HealthStatus = ApplicationLiveStateSnapshot_HEALTHY
 }
diff --git a/pkg/model/application_live_state_test.go b/pkg/model/application_live_state_test.go
@@ -168,6 +168,7 @@ func TestApplicationLiveStateSnapshot_DetermineAppHealthStatus(t *testing.T) {
 		})
 	}
 }
+
 func TestApplicationLiveStateSnapshot_DetermineApplicationHealthStatus(t *testing.T) {
 	testcases := []struct {
 		name     string
@@ -205,6 +206,18 @@ func TestApplicationLiveStateSnapshot_DetermineApplicationHealthStatus(t *testin
 			},
 			want: ApplicationLiveStateSnapshot_UNHEALTHY,
 		},
+		{
+			name: "unhealthy: prioritize unhealthy over unknown",
+			snapshot: &ApplicationLiveStateSnapshot{
+				ApplicationLiveState: &ApplicationLiveState{
+					Resources: []*ResourceState{
+						{HealthStatus: ResourceState_UNKNOWN},
+						{HealthStatus: ResourceState_UNHEALTHY},
+					},
+				},
+			},
+			want: ApplicationLiveStateSnapshot_UNHEALTHY,
+		},
 		{
 			name: "unknown: one of the resources is unknown",
 			snapshot: &ApplicationLiveStateSnapshot{