How about using AWS official structs in config for Lambda

[t-kikuc]

What to add

• Migrate from function.yaml(FunctionManifestSpec) to aws-sdk's structs like:
  • FunctionConfiguration
  • FunctionCode
    defined in the package github.com/aws/aws-sdk-go-v2/service/lambda/types

Background

• Currently, we use function.yaml, whose struct is defined by PipeCD, for configuring Lambda applications.

• The problem is that it's tough to follow the Lambda's new features, because we need to add options to the struct.

Note

• It will be a breaking change since the configuration file will be changed.

[t-kikuc]

I found it is so difficult because:

• Now we support fetching codes from Git repositories as below: (critical)
  

  pipecd/pkg/app/piped/executor/lambda/lambda.go

  Lines 355 to 365 in 51a49f9

  	func prepareZipFromSource(ctx context.Context, gc executor.GitClient, fm provider.FunctionManifest) (io.Reader, error) {
  	repo, err := gc.Clone(ctx, fm.Spec.SourceCode.Git, fm.Spec.SourceCode.Git, "", "")
  	if err != nil {
  	return nil, err
  	}
  	defer repo.Clean()
  	if err = repo.Checkout(ctx, fm.Spec.SourceCode.Ref); err != nil {
  	return nil, err
  	}

  
  

  pipecd/pkg/app/piped/platformprovider/lambda/function.go

  Lines 123 to 127 in 51a49f9

  	type SourceCode struct {
  	Git string `json:"git"`
  	Ref string `json:"ref"`
  	Path string `json:"path"`
  	}

• Official structs FunctionConfiguration and FunctionCode do not have Tags field. (not critical)

[t-kikuc]

One idea is creating the wrapping struct like LambdaManifest

type LambdaManifest struct{
    FunctionConfiguration types.FunctionConfiguration `json:"functionConfiguration"`
    FunctionCode          types.FunctionCode `json:"functionCode"`
    SourceCode           SourceCode `json:"sourceCode"`
}

 type SourceCode struct {  // existing one
 	Git  string `json:"git"` 
 	Ref  string `json:"ref"` 
 	Path string `json:"path"` 
 } 

The manifest would be like:

functionConfiguration: 
  functionName: my-func
  architectures:
    - xxx
    - yyy
  ephemeralStorage:
    size: xxx
  ...
functionCode:
  s3Bucket: xxx
  s3Key: yyy
  s3ObjectVersion: zzz
  ...
# sourceCode section is used if you deploy from Git directly
sourceCode:
  git: xxx
  ref: xxx
  path: xxx