Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve plan-preview message for Kubernetes application #2982

Closed
nghialv opened this issue Dec 23, 2021 · 1 comment
Closed

Improve plan-preview message for Kubernetes application #2982

nghialv opened this issue Dec 23, 2021 · 1 comment
Labels
area/piped good first issue Good for newcomers kind/enhancement New feature or request Stale

Comments

@nghialv
Copy link
Member

nghialv commented Dec 23, 2021

What would you like to be added:

PlanPreview determines and shows the list of manifests that should be added, deleted, updated once the PR got merged.
But actually, no one will be deleted if the prune field of the application is being disabled.
So PlanPreview should take care of that edge case for a better message.

https://pipecd.dev/docs/user-guide/plan-preview/

Why is this needed:
@nghialv nghialv added the kind/enhancement New feature or request label Dec 23, 2021
@ffjlabo ffjlabo added the Stale label Oct 4, 2024
@ffjlabo
Copy link
Member

ffjlabo commented Oct 4, 2024

We will create the enhanced issue for plan preview feature later.

@ffjlabo ffjlabo closed this as not planned Won't fix, can't repro, duplicate, stale Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/piped good first issue Good for newcomers kind/enhancement New feature or request Stale
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nghialv @kentakozuka @ffjlabo