Add ECSTargetGroupObject to the configuration reference documentation #4649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ouchi2501
requested review from
nghialv,
khanhtc1202,
kentakozuka and
ffjlabo
as code owners
Signed-off-by: uncle <[email protected]>
ouchi2501
force-pushed
the
add-doc-ecs-targetgroup-object
branch
from
8f12547 to
0b16370
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4649 +/- ##
=======================================
Coverage 30.61% 30.61%
=======================================
Files 221 221
Lines 25937 25937
=======================================
Hits 7941 7941
Misses 17348 17348
Partials 648 648 ☔ View full report in Codecov by Sentry. |
|
@ouchi2501 Nice catch 🙏 |
Signed-off-by: uncle <[email protected]>
|
@khanhtc1202 |
sZma5a
pushed a commit
to sZma5a/pipecd
that referenced
this pull request
Nov 5, 2023
…pipe-cd#4649) * Add ECSTargetGroupObject to the configuration reference documentation Signed-off-by: uncle <[email protected]> * Add docs-dev and Change markdown table formatting Signed-off-by: uncle <[email protected]> --------- Signed-off-by: uncle <[email protected]>
Merged
Merged
sZma5a
pushed a commit
to sZma5a/pipecd
that referenced
this pull request
Feb 12, 2024
…pipe-cd#4649) * Add ECSTargetGroupObject to the configuration reference documentation Signed-off-by: uncle <[email protected]> * Add docs-dev and Change markdown table formatting Signed-off-by: uncle <[email protected]> --------- Signed-off-by: uncle <[email protected]> Signed-off-by: 鈴木 優耀 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
I added ECSTargetGroupObject as it was not documented.
I didn't know to what extent I should add the document, so I added it only to the latest version first.
Please let me know if you need to add it to
docs-devor any other ver.Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: