Send error comment before plan preview exit #4658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TakumaKurosawa
requested review from
nghialv,
khanhtc1202,
kentakozuka and
ffjlabo
as code owners
Signed-off-by: Takumaron <[email protected]>
TakumaKurosawa
force-pushed
the
comment-before-os-exit
branch
from
a438f11 to
78f339e
Compare
khanhtc1202
reviewed
Nov 8, 2023
tool/actions-plan-preview/main.go
Outdated
| @@ -152,7 +154,7 @@ func main() { | |||
| return | |||
| } | |||
|
|
|||
| if bool(comment.IsMinimized) { | |||
| if comment.IsMinimized { | |||
There was a problem hiding this comment.
I think this cast is to ensure we can notice if the lib type Boolean changed, so let's keep it.
There was a problem hiding this comment.
I see your point👍
There was a problem hiding this comment.
@khanhtc1202
Applied!!
5aded83
|
Overall looks good, just left a small nit 😄 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4658 +/- ##
==========================================
+ Coverage 30.81% 30.83% +0.01%
==========================================
Files 221 221
Lines 25941 25941
==========================================
+ Hits 7995 7999 +4
+ Misses 17296 17292 -4
Partials 650 650 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Takumaron <[email protected]>
TakumaKurosawa
force-pushed
the
comment-before-os-exit
branch
from
449aa1b to
5aded83
Compare
ffjlabo
pushed a commit
that referenced
this pull request
Nov 13, 2023
* Send error comment before plan preview exit Signed-off-by: Takumaron <[email protected]> * Apply review commnet Signed-off-by: Takumaron <[email protected]> --------- Signed-off-by: Takumaron <[email protected]>
khanhtc1202
added a commit
that referenced
this pull request
Nov 13, 2023
#4628 #4629 #4631 #4632 #4633 #4637 #4638 #4641 #4648 #4650 #4656 #4658 #4662 #4666 (#4669) * Bump golang.org/x/net from 0.7.0 to 0.17.0 in /tool/actions-plan-preview (#4611) Bumps [golang.org/x/net](https://github.com/golang/net) from 0.7.0 to 0.17.0. - [Commits](golang/net@v0.7.0...v0.17.0) --- updated-dependencies: - dependency-name: golang.org/x/net dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump golang.org/x/net from 0.7.0 to 0.17.0 in /tool/actions-gh-release (#4612) Bumps [golang.org/x/net](https://github.com/golang/net) from 0.7.0 to 0.17.0. - [Commits](golang/net@v0.7.0...v0.17.0) --- updated-dependencies: - dependency-name: golang.org/x/net dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Khanh Tran <[email protected]> * Bump golang.org/x/net from 0.8.0 to 0.17.0 (#4613) Bumps [golang.org/x/net](https://github.com/golang/net) from 0.8.0 to 0.17.0. - [Commits](golang/net@v0.8.0...v0.17.0) --- updated-dependencies: - dependency-name: golang.org/x/net dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump @babel/traverse from 7.14.7 to 7.23.2 in /web (#4619) * Fix part of lint/go errors (misspell, depguard, unconvert) (#4621) * Fix lint/go errors (misspell) Signed-off-by: karamaru-alpha <[email protected]> * Fix lint/go errors (depguard) Signed-off-by: karamaru-alpha <[email protected]> * Fix lint/go errors (unconvert) Signed-off-by: karamaru-alpha <[email protected]> --------- Signed-off-by: karamaru-alpha <[email protected]> * Fix part of lint/go errors (goimports, staticcheck, gosimple) (#4622) * Fix lint/go errors (goimport) Signed-off-by: karamaru-alpha <[email protected]> * Fix lint/go errors (staticcheck) Signed-off-by: karamaru-alpha <[email protected]> * Fix lint/go errors (gosimple) Signed-off-by: karamaru-alpha <[email protected]> * Fix lint/go errors (gosimple) Signed-off-by: karamaru-alpha <[email protected]> * Fix return error by function Signed-off-by: karamaru-alpha <[email protected]> --------- Signed-off-by: karamaru-alpha <[email protected]> * Fix part of lint/go errors (deadcode, ineffassign, depguard) (#4624) * Ignore mannwhitney from golangci-lint Signed-off-by: karamaru-alpha <[email protected]> * Fix lint/go errors (deadcode) Signed-off-by: karamaru-alpha <[email protected]> * Fix lint/go errors (depguard) Signed-off-by: karamaru-alpha <[email protected]> --------- Signed-off-by: karamaru-alpha <[email protected]> * Add tests to terraform platform provider (#4625) Signed-off-by: Kenta Kozuka <[email protected]> * Add tests to apikey model (#4626) Signed-off-by: Kenta Kozuka <[email protected]> * Add tests to application model (#4627) Signed-off-by: Kenta Kozuka <[email protected]> * Reduce `make lint/go` execution time by adding the GOCACHE environment variable (#4628) * Add GOCACHE env to lint/go Signed-off-by: karamaru-alpha <[email protected]> * Add verbose flag to lint/go Signed-off-by: karamaru-alpha <[email protected]> * Change timeout golangci.yml Signed-off-by: karamaru-alpha <[email protected]> --------- Signed-off-by: karamaru-alpha <[email protected]> * Add tests to model/deployment (#4629) Signed-off-by: Kenta Kozuka <[email protected]> * Add tests to model/notificationevent (#4631) * Add tests to model/notificationevent Signed-off-by: Kenta Kozuka <[email protected]> * Add Parallel() Signed-off-by: Kenta Kozuka <[email protected]> --------- Signed-off-by: Kenta Kozuka <[email protected]> * Add tests to model/deployment_chain (#4632) * Bump google.golang.org/grpc from 1.54.0 to 1.56.3 (#4633) * Bump google.golang.org/grpc from 1.54.0 to 1.56.3 Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.54.0 to 1.56.3. - [Release notes](https://github.com/grpc/grpc-go/releases) - [Commits](grpc/grpc-go@v1.54.0...v1.56.3) --- updated-dependencies: - dependency-name: google.golang.org/grpc dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> * Update grpc test version Signed-off-by: khanhtc1202 <[email protected]> --------- Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: khanhtc1202 <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: khanhtc1202 <[email protected]> * Fix lint/go errors (gocritic) (#4637) Signed-off-by: karamaru-alpha <[email protected]> * Fix part of lint/go errors (stylecheck) (#4638) * Fix lint/go errors (stylecheck) Signed-off-by: karamaru-alpha <[email protected]> * Remove nolint:stylecheck Signed-off-by: karamaru-alpha <[email protected]> * Change method reveiver name Signed-off-by: karamaru-alpha <[email protected]> * Change receiver name k to ak Signed-off-by: karamaru-alpha <[email protected]> --------- Signed-off-by: karamaru-alpha <[email protected]> * Bump github.com/docker/docker (#4641) * Make actions plan preview handle timeout option (#4648) * Format and make tests pass in tool/actions-plan-preview Signed-off-by: mi11km <[email protected]> * Use --piped-handle-timeout to make the timeout arg activate Signed-off-by: mi11km <[email protected]> * Add tests to model/notificationevent (#4631) * Add tests to model/notificationevent Signed-off-by: Kenta Kozuka <[email protected]> * Add Parallel() Signed-off-by: Kenta Kozuka <[email protected]> --------- Signed-off-by: Kenta Kozuka <[email protected]> Signed-off-by: mi11km <[email protected]> * add piped-handle-timeout(input args) Signed-off-by: mi11km <[email protected]> --------- Signed-off-by: mi11km <[email protected]> Signed-off-by: Kenta Kozuka <[email protected]> Co-authored-by: Kenta Kozuka <[email protected]> Co-authored-by: Khanh Tran <[email protected]> * Fix panic error in ListDeployments API (#4650) * Update golangci-lint and fix lint errors (#4656) Signed-off-by: karamaru-alpha <[email protected]> * Send error comment before plan preview exit (#4658) * Send error comment before plan preview exit Signed-off-by: Takumaron <[email protected]> * Apply review commnet Signed-off-by: Takumaron <[email protected]> --------- Signed-off-by: Takumaron <[email protected]> * Handle plan preview workflow's error and exit with error status code (#4662) * Add a flag to skip running standalone task during deployment (#4666) * Add a flag to skip running standalone task during deployment Signed-off-by: Kenta Kozuka <[email protected]> * Fix docs Signed-off-by: Kenta Kozuka <[email protected]> --------- Signed-off-by: Kenta Kozuka <[email protected]> --------- Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: karamaru-alpha <[email protected]> Signed-off-by: Kenta Kozuka <[email protected]> Signed-off-by: khanhtc1202 <[email protected]> Signed-off-by: mi11km <[email protected]> Signed-off-by: Takumaron <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Khanh Tran <[email protected]> Co-authored-by: karamaru <[email protected]> Co-authored-by: Kenta Kozuka <[email protected]> Co-authored-by: khanhtc1202 <[email protected]> Co-authored-by: Masafumi Ikeyama <[email protected]> Co-authored-by: Seitaro Fujigaki <[email protected]> Co-authored-by: Kurosawa Takuma <[email protected]>
Merged
sZma5a
pushed a commit
to sZma5a/pipecd
that referenced
this pull request
Dec 17, 2023
* Send error comment before plan preview exit Signed-off-by: Takumaron <[email protected]> * Apply review commnet Signed-off-by: Takumaron <[email protected]> --------- Signed-off-by: Takumaron <[email protected]>
sZma5a
pushed a commit
to sZma5a/pipecd
that referenced
this pull request
Dec 17, 2023
* Send error comment before plan preview exit Signed-off-by: Takumaron <[email protected]> * Apply review commnet Signed-off-by: Takumaron <[email protected]> --------- Signed-off-by: Takumaron <[email protected]>
Merged
sZma5a
pushed a commit
to sZma5a/pipecd
that referenced
this pull request
Feb 12, 2024
* Send error comment before plan preview exit Signed-off-by: Takumaron <[email protected]> * Apply review commnet Signed-off-by: Takumaron <[email protected]> --------- Signed-off-by: Takumaron <[email protected]> Signed-off-by: 鈴木 優耀 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
It's hard to know why plan-preview exited.
Sending error comment before exiting makes us easier to find the problem.
Which issue(s) this PR fixes:
Fixes #4657
Does this PR introduce a user-facing change?:
error comment will displayed before plan-preview exiting
Is this breaking change:
How to migrate (if breaking change):