-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add v2 to versionWhitelist #4682
Conversation
Signed-off-by: Yoshiki Fujikane <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4682 +/- ##
==========================================
- Coverage 30.82% 30.80% -0.03%
==========================================
Files 221 221
Lines 25935 25935
==========================================
- Hits 7995 7989 -6
- Misses 17289 17296 +7
+ Partials 651 650 -1 ☔ View full report in Codecov by Sentry. |
note: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch 👍
Signed-off-by: Yoshiki Fujikane <[email protected]> Signed-off-by: t-kikuc <[email protected]>
This reverts commit ca80d46.
This reverts commit ca80d46. Signed-off-by: t-kikuc <[email protected]>
Signed-off-by: Yoshiki Fujikane <[email protected]>
* add ephemeralStorage option to lambda config (#4680) * add ephemeralStorage option to lambda config Signed-off-by: nnnkkk7 <[email protected]> Signed-off-by: nnnkkk7 <[email protected]> * add nil pointer check Signed-off-by: nnnkkk7 <[email protected]> * add EphemeralStorage input to CreateFunctionFromSource Signed-off-by: nnnkkk7 <[email protected]> * fix condition Signed-off-by: nnnkkk7 <[email protected]> --------- Signed-off-by: nnnkkk7 <[email protected]> * Add v2 to versionWhitelist (#4682) Signed-off-by: Yoshiki Fujikane <[email protected]> * [ECS] Tag to the new taskset in rollback (fixes #4692) (#4695) * Tag to new taskset in rollback Signed-off-by: t-kikuc <[email protected]> * Fix #4692 (ECS excess tasksets) Signed-off-by: t-kikuc <[email protected]> --------- Signed-off-by: t-kikuc <[email protected]> --------- Signed-off-by: nnnkkk7 <[email protected]> Signed-off-by: Yoshiki Fujikane <[email protected]> Signed-off-by: t-kikuc <[email protected]> Co-authored-by: naoki kuroda <[email protected]> Co-authored-by: Yoshiki Fujikane <[email protected]> Co-authored-by: Tetsuya Kikuchi <[email protected]>
Signed-off-by: Yoshiki Fujikane <[email protected]>
Signed-off-by: Yoshiki Fujikane <[email protected]>
Signed-off-by: Yoshiki Fujikane <[email protected]> Signed-off-by: sZma5a <[email protected]>
Signed-off-by: Yoshiki Fujikane <[email protected]> Signed-off-by: 鈴木 優耀 <[email protected]>
What this PR does / why we need it:
Added "v2" to versionWhitelist to recognize "autoscaling/v2" which is built-in resource
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: