Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add v2 to versionWhitelist #4682

Merged
merged 1 commit into from
Nov 21, 2023
Merged

Add v2 to versionWhitelist #4682

merged 1 commit into from
Nov 21, 2023

Conversation

ffjlabo
Copy link
Member

@ffjlabo ffjlabo commented Nov 21, 2023

What this PR does / why we need it:

Added "v2" to versionWhitelist to recognize "autoscaling/v2" which is built-in resource

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

Signed-off-by: Yoshiki Fujikane <[email protected]>
Copy link

codecov bot commented Nov 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8a4235b) 30.82% compared to head (32c3a54) 30.80%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4682      +/-   ##
==========================================
- Coverage   30.82%   30.80%   -0.03%     
==========================================
  Files         221      221              
  Lines       25935    25935              
==========================================
- Hits         7995     7989       -6     
- Misses      17289    17296       +7     
+ Partials      651      650       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ffjlabo
Copy link
Member Author

ffjlabo commented Nov 21, 2023

note:
Some versions also exists, but now added v2 for the resources only supported by PipeCD like HorizontalPodAutoscaler
https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.28/#-strong-api-groups-strong

Copy link
Member

@khanhtc1202 khanhtc1202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch 👍

@khanhtc1202 khanhtc1202 merged commit 8bad596 into master Nov 21, 2023
13 of 14 checks passed
@khanhtc1202 khanhtc1202 deleted the add-api-version branch November 21, 2023 07:31
t-kikuc pushed a commit to t-kikuc/pipecd that referenced this pull request Nov 27, 2023
Signed-off-by: Yoshiki Fujikane <[email protected]>
Signed-off-by: t-kikuc <[email protected]>
t-kikuc added a commit to t-kikuc/pipecd that referenced this pull request Nov 27, 2023
t-kikuc added a commit to t-kikuc/pipecd that referenced this pull request Nov 27, 2023
@github-actions github-actions bot mentioned this pull request Dec 1, 2023
khanhtc1202 pushed a commit that referenced this pull request Dec 1, 2023
khanhtc1202 added a commit that referenced this pull request Dec 1, 2023
* add ephemeralStorage option to lambda config (#4680)

* add ephemeralStorage option to lambda config

Signed-off-by: nnnkkk7 <[email protected]>

Signed-off-by: nnnkkk7 <[email protected]>

* add nil pointer check

Signed-off-by: nnnkkk7 <[email protected]>

* add EphemeralStorage input to CreateFunctionFromSource

Signed-off-by: nnnkkk7 <[email protected]>

* fix condition

Signed-off-by: nnnkkk7 <[email protected]>

---------

Signed-off-by: nnnkkk7 <[email protected]>

* Add v2 to versionWhitelist (#4682)

Signed-off-by: Yoshiki Fujikane <[email protected]>

* [ECS] Tag to the new taskset in rollback (fixes #4692) (#4695)

* Tag to new taskset in rollback

Signed-off-by: t-kikuc <[email protected]>

* Fix #4692 (ECS excess tasksets)

Signed-off-by: t-kikuc <[email protected]>

---------

Signed-off-by: t-kikuc <[email protected]>

---------

Signed-off-by: nnnkkk7 <[email protected]>
Signed-off-by: Yoshiki Fujikane <[email protected]>
Signed-off-by: t-kikuc <[email protected]>
Co-authored-by: naoki kuroda <[email protected]>
Co-authored-by: Yoshiki Fujikane <[email protected]>
Co-authored-by: Tetsuya Kikuchi <[email protected]>
sZma5a pushed a commit to sZma5a/pipecd that referenced this pull request Dec 17, 2023
sZma5a pushed a commit to sZma5a/pipecd that referenced this pull request Dec 17, 2023
sZma5a pushed a commit to sZma5a/pipecd that referenced this pull request Dec 17, 2023
Signed-off-by: Yoshiki Fujikane <[email protected]>
Signed-off-by: sZma5a <[email protected]>
@github-actions github-actions bot mentioned this pull request Feb 6, 2024
sZma5a pushed a commit to sZma5a/pipecd that referenced this pull request Feb 12, 2024
Signed-off-by: Yoshiki Fujikane <[email protected]>
Signed-off-by: 鈴木 優耀 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants